ref_transaction_update(): remove "have_old" parameter

Instead, verify the reference's old value if and only if old_sha1 is
non-NULL.

ref_transaction_delete() will get the same treatment in a moment.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Reviewed-by: Stefan Beller <sbeller@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/branch.c b/branch.c
index 4bab55a9a85e187e2a3906312f1e771f4a214f45..b0024353f4409c8b54c4b569b8fb7c435b26cdae 100644 (file)
--- a/branch.c
+++ b/branch.c
@@ -284,8 +284,9 @@ void create_branch(const char *head,
 
                transaction = ref_transaction_begin(&err);
                if (!transaction ||
 
                transaction = ref_transaction_begin(&err);
                if (!transaction ||

-                   ref_transaction_update(transaction, ref.buf, sha1,
-                                          null_sha1, 0, !forcing, msg, &err) ||
+                   ref_transaction_update(transaction, ref.buf,
+                                          sha1, forcing ? NULL : null_sha1,
+                                          0, msg, &err) ||

                    ref_transaction_commit(transaction, &err))
                        die("%s", err.buf);
                ref_transaction_free(transaction);
                    ref_transaction_commit(transaction, &err))
                        die("%s", err.buf);
                ref_transaction_free(transaction);

diff --git a/builtin/commit.c b/builtin/commit.c
index 7f467133b88c10e2440c878a0218bee981b3acd7..8afb0ff5e044719b1d2266231d1d2881e4d93f21 100644 (file)
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -1767,7 +1767,7 @@ int cmd_commit(int argc, const char **argv, const char *prefix)
            ref_transaction_update(transaction, "HEAD", sha1,
                                   current_head
                                   ? current_head->object.sha1 : NULL,
            ref_transaction_update(transaction, "HEAD", sha1,
                                   current_head
                                   ? current_head->object.sha1 : NULL,

-                                  0, !!current_head, sb.buf, &err) ||
+                                  0, sb.buf, &err) ||

            ref_transaction_commit(transaction, &err)) {
                rollback_index_files();
                die("%s", err.buf);
            ref_transaction_commit(transaction, &err)) {
                rollback_index_files();
                die("%s", err.buf);

diff --git a/builtin/fetch.c b/builtin/fetch.c
index 7b84d35d83498bc51b06915818f63d1f365eec91..719bf4f244ba5e6dcb40c9c8e578aa1cdfeee53e 100644 (file)
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -416,8 +416,10 @@ static int s_update_ref(const char *action,
 
        transaction = ref_transaction_begin(&err);
        if (!transaction ||
 
        transaction = ref_transaction_begin(&err);
        if (!transaction ||

-           ref_transaction_update(transaction, ref->name, ref->new_sha1,
-                                  ref->old_sha1, 0, check_old, msg, &err))
+           ref_transaction_update(transaction, ref->name,
+                                  ref->new_sha1,
+                                  check_old ? ref->old_sha1 : NULL,
+                                  0, msg, &err))

                goto fail;
 
        ret = ref_transaction_commit(transaction, &err);
                goto fail;
 
        ret = ref_transaction_commit(transaction, &err);

diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
index e0ce78e5a069670b00da6f3d67b991525c6dd29c..0be50e95401561eca0b379fa5203ec17f007ca41 100644 (file)
--- a/builtin/receive-pack.c
+++ b/builtin/receive-pack.c
@@ -971,7 +971,7 @@ static const char *update(struct command *cmd, struct shallow_info *si)
                if (ref_transaction_update(transaction,
                                           namespaced_name,
                                           new_sha1, old_sha1,
                if (ref_transaction_update(transaction,
                                           namespaced_name,
                                           new_sha1, old_sha1,

-                                          0, 1, "push",
+                                          0, "push",

                                           &err)) {
                        rp_error("%s", err.buf);
                        strbuf_release(&err);
                                           &err)) {
                        rp_error("%s", err.buf);
                        strbuf_release(&err);

diff --git a/builtin/replace.c b/builtin/replace.c
index 85d39b58d8aa35f0cd644273821ffd047ac50df0..54bf01acb4ca060a1dae43b399a6aefb1abe4eee 100644 (file)
--- a/builtin/replace.c
+++ b/builtin/replace.c
@@ -172,7 +172,7 @@ static int replace_object_sha1(const char *object_ref,
        transaction = ref_transaction_begin(&err);
        if (!transaction ||
            ref_transaction_update(transaction, ref, repl, prev,
        transaction = ref_transaction_begin(&err);
        if (!transaction ||
            ref_transaction_update(transaction, ref, repl, prev,

-                                  0, 1, NULL, &err) ||
+                                  0, NULL, &err) ||

            ref_transaction_commit(transaction, &err))
                die("%s", err.buf);
 
            ref_transaction_commit(transaction, &err))
                die("%s", err.buf);
 

diff --git a/builtin/tag.c b/builtin/tag.c
index 6dc85a9d5e16e921a99a9f90c5d1f453bf9450bd..4194b9a711d88e6d3575cd8896b1a81de74b087f 100644 (file)
--- a/builtin/tag.c
+++ b/builtin/tag.c
@@ -733,7 +733,7 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
        transaction = ref_transaction_begin(&err);
        if (!transaction ||
            ref_transaction_update(transaction, ref.buf, object, prev,
        transaction = ref_transaction_begin(&err);
        if (!transaction ||
            ref_transaction_update(transaction, ref.buf, object, prev,

-                                  0, 1, NULL, &err) ||
+                                  0, NULL, &err) ||

            ref_transaction_commit(transaction, &err))
                die("%s", err.buf);
        ref_transaction_free(transaction);
            ref_transaction_commit(transaction, &err))
                die("%s", err.buf);
        ref_transaction_free(transaction);

diff --git a/builtin/update-ref.c b/builtin/update-ref.c
index 9a1659e11eba303f93924f3a0866b8955564652c..1ad6ce1877ed203ec2593aeb1bd12cc6282fdae7 100644 (file)
--- a/builtin/update-ref.c
+++ b/builtin/update-ref.c
@@ -198,8 +198,9 @@ static const char *parse_cmd_update(struct ref_transaction *transaction,
        if (*next != line_termination)
                die("update %s: extra input: %s", refname, next);
 
        if (*next != line_termination)
                die("update %s: extra input: %s", refname, next);
 

-       if (ref_transaction_update(transaction, refname, new_sha1, old_sha1,
-                                  update_flags, have_old, msg, &err))
+       if (ref_transaction_update(transaction, refname,
+                                  new_sha1, have_old ? old_sha1 : NULL,
+                                  update_flags, msg, &err))

                die("%s", err.buf);
 
        update_flags = 0;
                die("%s", err.buf);
 
        update_flags = 0;


@@ -297,7 +298,7 @@ static const char *parse_cmd_verify(struct ref_transaction *transaction,
                die("verify %s: extra input: %s", refname, next);
 
        if (ref_transaction_update(transaction, refname, new_sha1, old_sha1,
                die("verify %s: extra input: %s", refname, next);
 
        if (ref_transaction_update(transaction, refname, new_sha1, old_sha1,

-                                  update_flags, 1, msg, &err))
+                                  update_flags, msg, &err))

                die("%s", err.buf);
 
        update_flags = 0;
                die("%s", err.buf);
 
        update_flags = 0;

diff --git a/fast-import.c b/fast-import.c
index d0bd285a16d0161b50d0b43e0315f8fa003e0e32..1e72bfbd4c6a7fabbc3fb447696b4101db5463db 100644 (file)
--- a/fast-import.c
+++ b/fast-import.c
@@ -1716,7 +1716,7 @@ static int update_branch(struct branch *b)
        transaction = ref_transaction_begin(&err);
        if (!transaction ||
            ref_transaction_update(transaction, b->name, b->sha1, old_sha1,
        transaction = ref_transaction_begin(&err);
        if (!transaction ||
            ref_transaction_update(transaction, b->name, b->sha1, old_sha1,

-                                  0, 1, msg, &err) ||
+                                  0, msg, &err) ||

            ref_transaction_commit(transaction, &err)) {
                ref_transaction_free(transaction);
                error("%s", err.buf);
            ref_transaction_commit(transaction, &err)) {
                ref_transaction_free(transaction);
                error("%s", err.buf);


@@ -1756,8 +1756,8 @@ static void dump_tags(void)
                strbuf_reset(&ref_name);
                strbuf_addf(&ref_name, "refs/tags/%s", t->name);
 
                strbuf_reset(&ref_name);
                strbuf_addf(&ref_name, "refs/tags/%s", t->name);
 

-               if (ref_transaction_update(transaction, ref_name.buf, t->sha1,
-                                          NULL, 0, 0, msg, &err)) {
+               if (ref_transaction_update(transaction, ref_name.buf,
+                                          t->sha1, NULL, 0, msg, &err)) {

                        failure |= error("%s", err.buf);
                        goto cleanup;
                }
                        failure |= error("%s", err.buf);
                        goto cleanup;
                }

diff --git a/refs.c b/refs.c
index e3a2ba8bd7991fd70244b18f9fc9d5ff31b73ce2..e88817c623e687804a6e2e911f64704e456cbe32 100644 (file)
--- a/refs.c
+++ b/refs.c
@@ -3654,7 +3654,7 @@ int ref_transaction_update(struct ref_transaction *transaction,
                           const char *refname,
                           const unsigned char *new_sha1,
                           const unsigned char *old_sha1,
                           const char *refname,
                           const unsigned char *new_sha1,
                           const unsigned char *old_sha1,

-                          unsigned int flags, int have_old, const char *msg,
+                          unsigned int flags, const char *msg,

                           struct strbuf *err)
 {
        struct ref_update *update;
                           struct strbuf *err)
 {
        struct ref_update *update;


@@ -3664,9 +3664,6 @@ int ref_transaction_update(struct ref_transaction *transaction,
        if (transaction->state != REF_TRANSACTION_OPEN)
                die("BUG: update called for transaction that is not open");
 
        if (transaction->state != REF_TRANSACTION_OPEN)
                die("BUG: update called for transaction that is not open");
 

-       if (have_old && !old_sha1)
-               die("BUG: have_old is true but old_sha1 is NULL");
-

        if (!is_null_sha1(new_sha1) &&
            check_refname_format(refname, REFNAME_ALLOW_ONELEVEL)) {
                strbuf_addf(err, "refusing to update ref with bad name %s",
        if (!is_null_sha1(new_sha1) &&
            check_refname_format(refname, REFNAME_ALLOW_ONELEVEL)) {
                strbuf_addf(err, "refusing to update ref with bad name %s",


@@ -3676,7 +3673,7 @@ int ref_transaction_update(struct ref_transaction *transaction,
 
        update = add_update(transaction, refname);
        hashcpy(update->new_sha1, new_sha1);
 
        update = add_update(transaction, refname);
        hashcpy(update->new_sha1, new_sha1);

-       if (have_old) {
+       if (old_sha1) {

                hashcpy(update->old_sha1, old_sha1);
                flags |= REF_HAVE_OLD;
        }
                hashcpy(update->old_sha1, old_sha1);
                flags |= REF_HAVE_OLD;
        }


@@ -3693,7 +3690,7 @@ int ref_transaction_create(struct ref_transaction *transaction,
                           struct strbuf *err)
 {
        return ref_transaction_update(transaction, refname, new_sha1,
                           struct strbuf *err)
 {
        return ref_transaction_update(transaction, refname, new_sha1,

-                                     null_sha1, flags, 1, msg, err);
+                                     null_sha1, flags, msg, err);

 }
 
 int ref_transaction_delete(struct ref_transaction *transaction,
 }
 
 int ref_transaction_delete(struct ref_transaction *transaction,


@@ -3702,8 +3699,9 @@ int ref_transaction_delete(struct ref_transaction *transaction,
                           unsigned int flags, int have_old, const char *msg,
                           struct strbuf *err)
 {
                           unsigned int flags, int have_old, const char *msg,
                           struct strbuf *err)
 {

-       return ref_transaction_update(transaction, refname, null_sha1,
-                                     old_sha1, flags, have_old, msg, err);
+       return ref_transaction_update(transaction, refname,
+                                     null_sha1, have_old ? old_sha1 : NULL,
+                                     flags, msg, err);

 }
 
 int update_ref(const char *action, const char *refname,
 }
 
 int update_ref(const char *action, const char *refname,


@@ -3715,8 +3713,8 @@ int update_ref(const char *action, const char *refname,
 
        t = ref_transaction_begin(&err);
        if (!t ||
 
        t = ref_transaction_begin(&err);
        if (!t ||

-           ref_transaction_update(t, refname, sha1, oldval, flags,
-                                  !!oldval, action, &err) ||
+           ref_transaction_update(t, refname, sha1, oldval,
+                                  flags, action, &err) ||

            ref_transaction_commit(t, &err)) {
                const char *str = "update_ref failed for ref '%s': %s";
 
            ref_transaction_commit(t, &err)) {
                const char *str = "update_ref failed for ref '%s': %s";
 

diff --git a/refs.h b/refs.h
index 92b85979c1239bbb67003e9c525c6f4e96e4024d..dced4c9464cfdfe9257634a766d8557767d03b5a 100644 (file)
--- a/refs.h
+++ b/refs.h
@@ -265,8 +265,8 @@ struct ref_transaction *ref_transaction_begin(struct strbuf *err);
 /*
  * Add a reference update to transaction.  new_sha1 is the value that
  * the reference should have after the update, or null_sha1 if it should
 /*
  * Add a reference update to transaction.  new_sha1 is the value that
  * the reference should have after the update, or null_sha1 if it should

- * be deleted.  If have_old is true, then old_sha1 holds the value
- * that the reference should have had before the update, or zeros if
+ * be deleted.  If old_sha1 is non-NULL, then it is the value
+ * that the reference should have had before the update, or null_sha1 if

  * it must not have existed beforehand.
  * Function returns 0 on success and non-zero on failure. A failure to update
  * means that the transaction as a whole has failed and will need to be
  * it must not have existed beforehand.
  * Function returns 0 on success and non-zero on failure. A failure to update
  * means that the transaction as a whole has failed and will need to be


@@ -276,7 +276,7 @@ int ref_transaction_update(struct ref_transaction *transaction,
                           const char *refname,
                           const unsigned char *new_sha1,
                           const unsigned char *old_sha1,
                           const char *refname,
                           const unsigned char *new_sha1,
                           const unsigned char *old_sha1,

-                          unsigned int flags, int have_old, const char *msg,
+                          unsigned int flags, const char *msg,

                           struct strbuf *err);
 
 /*
                           struct strbuf *err);
 
 /*

diff --git a/sequencer.c b/sequencer.c
index 77a1266760718b8e5b029636409634e241981888..32aa05ed828dfa3bac79edb83dd8a222560206d3 100644 (file)
--- a/sequencer.c
+++ b/sequencer.c
@@ -252,7 +252,7 @@ static int fast_forward_to(const unsigned char *to, const unsigned char *from,
        if (!transaction ||
            ref_transaction_update(transaction, "HEAD",
                                   to, unborn ? null_sha1 : from,
        if (!transaction ||
            ref_transaction_update(transaction, "HEAD",
                                   to, unborn ? null_sha1 : from,

-                                  0, 1, sb.buf, &err) ||
+                                  0, sb.buf, &err) ||

            ref_transaction_commit(transaction, &err)) {
                ref_transaction_free(transaction);
                error("%s", err.buf);
            ref_transaction_commit(transaction, &err)) {
                ref_transaction_free(transaction);
                error("%s", err.buf);

diff --git a/walker.c b/walker.c
index 483da4e0fb5771b8a64d62648624258dcf3fdcb0..58ffeca264b765326a234b21356a02a3152e1c38 100644 (file)
--- a/walker.c
+++ b/walker.c
@@ -299,7 +299,7 @@ int walker_fetch(struct walker *walker, int targets, char **target,
                strbuf_reset(&refname);
                strbuf_addf(&refname, "refs/%s", write_ref[i]);
                if (ref_transaction_update(transaction, refname.buf,
                strbuf_reset(&refname);
                strbuf_addf(&refname, "refs/%s", write_ref[i]);
                if (ref_transaction_update(transaction, refname.buf,

-                                          &sha1[20 * i], NULL, 0, 0,
+                                          &sha1[20 * i], NULL, 0,

                                           msg ? msg : "fetch (unknown)",
                                           &err)) {
                        error("%s", err.buf);
                                           msg ? msg : "fetch (unknown)",
                                           &err)) {
                        error("%s", err.buf);