mingw: follow-up to "replace isatty() hack"
authorJohannes Schindelin <johannes.schindelin@gmx.de>
Wed, 18 Jan 2017 12:14:35 +0000 (13:14 +0100)
committerJunio C Hamano <gitster@pobox.com>
Wed, 18 Jan 2017 21:31:25 +0000 (13:31 -0800)
The version of the "replace isatty() hack" that got merged a few
weeks ago did not actually reflect the latest iteration of the patch
series: v3 was sent out with these changes, as requested by the
reviewer Johannes Sixt:

- reworded the comment about "recycling handles"

- moved the reassignment of the `console` variable before the dup2()
call so that it is valid at all times

- removed the "handle = INVALID_HANDLE_VALUE" assignment, as the local
variable `handle` is not used afterwards anyway

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Reviewed-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
No differences found