configure.ac: fix botched FREAD_READS_DIRECTORIES check
authorEric Sunshine <sunshine@sunshineco.com>
Mon, 9 Apr 2018 08:50:42 +0000 (04:50 -0400)
committerJunio C Hamano <gitster@pobox.com>
Mon, 9 Apr 2018 09:50:35 +0000 (18:50 +0900)
3adf9fdecf (configure.ac: loosen FREAD_READS_DIRECTORIES test program,
2017-06-14) broke the test program for the FREAD_READS_DIRECTORIES check
by making it syntactically invalid (a dangling ")") and by botching the
type returned from 'main' (a FILE* rather than int). As a consequence,
the test program won't even compile, thus the check fails
unconditionally. Fix these problems.

Reported-by: Jonathan Primrose <jprimros@gmail.com>
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
configure.ac
index ceeb9de57566000c9199887d9207b0be3c416e78..e33b6c79c0d120fcbda00ce14cc461d6de71c690 100644 (file)
@@ -867,7 +867,7 @@ AC_RUN_IFELSE(
        [AC_LANG_PROGRAM([AC_INCLUDES_DEFAULT],
                [[
                FILE *f = fopen(".", "r");
-               return f)]])],
+               return f != NULL;]])],
        [ac_cv_fread_reads_directories=no],
        [ac_cv_fread_reads_directories=yes])
 ])