Merge branch 'jk/bisect-prn-unsigned'
authorJunio C Hamano <gitster@pobox.com>
Sun, 7 Apr 2013 21:32:54 +0000 (14:32 -0700)
committerJunio C Hamano <gitster@pobox.com>
Sun, 7 Apr 2013 21:32:54 +0000 (14:32 -0700)
* jk/bisect-prn-unsigned:
bisect: avoid signed integer overflow

bisect.c
index bd1b7b5dac81ada592a16630214d1f2cbb655b88..374d9e24bd0a18b0453f3e948db93251a859ba18 100644 (file)
--- a/bisect.c
+++ b/bisect.c
@@ -525,9 +525,9 @@ struct commit_list *filter_skipped(struct commit_list *list,
  * is increased by one between each call, but that should not matter
  * for this application.
  */
-static int get_prn(int count) {
+static unsigned get_prn(unsigned count) {
        count = count * 1103515245 + 12345;
-       return ((unsigned)(count/65536) % PRN_MODULO);
+       return (count/65536) % PRN_MODULO;
 }
 
 /*