blame.c: Properly initialize strbuf after calling, textconv_object()
authorSebastian Schuberth <sschuberth@gmail.com>
Fri, 28 Oct 2011 15:28:28 +0000 (17:28 +0200)
committerJunio C Hamano <gitster@pobox.com>
Fri, 28 Oct 2011 15:41:56 +0000 (08:41 -0700)
For a plain string where only the length is known, strbuf.alloc needs to
be initialized to the length. Otherwise strbuf.alloc is 0 and a later
call to strbuf_setlen() will fail.

This bug surfaced when calling git blame under Windows on a *.doc file.
The *.doc file is converted to plain text by antiword via the textconv
mechanism. However, the plain text returned by antiword contains DOS line
endings instead of Unix line endings which triggered the strbuf_setlen()
which previous to this patch failed.

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/blame.c
index 173f286b193111c85f692cba13fd4c8c632d46b0..e39d9865e2d3f8db10ef2f43b9a2d07ad0b61df9 100644 (file)
@@ -2094,8 +2094,10 @@ static struct commit *fake_working_tree_commit(struct diff_options *opt,
                switch (st.st_mode & S_IFMT) {
                case S_IFREG:
                        if (DIFF_OPT_TST(opt, ALLOW_TEXTCONV) &&
-                           textconv_object(read_from, mode, null_sha1, &buf.buf, &buf_len))
+                           textconv_object(read_from, mode, null_sha1, &buf.buf, &buf_len)) {
+                               buf.alloc = buf_len;
                                buf.len = buf_len;
+                       }
                        else if (strbuf_read_file(&buf, read_from, st.st_size) != st.st_size)
                                die_errno("cannot open or read '%s'", read_from);
                        break;