t0021/rot13-filter: add packet_initialize()
authorChristian Couder <christian.couder@gmail.com>
Sun, 5 Nov 2017 21:38:33 +0000 (22:38 +0100)
committerJunio C Hamano <gitster@pobox.com>
Tue, 7 Nov 2017 00:54:41 +0000 (09:54 +0900)
Let's refactor the code to initialize communication into its own
packet_initialize() function, so that we can reuse this
functionality in following patches.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t0021/rot13-filter.pl
index f31ff595fedcd39c1420a002b4cb5957e5d190b6..2f74ab2e45c169f8fe3f984296ea33c2371e9dc5 100644 (file)
@@ -127,19 +127,25 @@ sub packet_flush {
        STDOUT->flush();
 }
 
+sub packet_initialize {
+       my ($name, $version) = @_;
+
+       packet_compare_lists([0, $name . "-client"], packet_txt_read()) ||
+               die "bad initialize";
+       packet_compare_lists([0, "version=" . $version], packet_txt_read()) ||
+               die "bad version";
+       packet_compare_lists([1, ""], packet_bin_read()) ||
+               die "bad version end";
+
+       packet_txt_write( $name . "-server" );
+       packet_txt_write( "version=" . $version );
+       packet_flush();
+}
+
 print $debug "START\n";
 $debug->flush();
 
-packet_compare_lists([0, "git-filter-client"], packet_txt_read()) ||
-       die "bad initialize";
-packet_compare_lists([0, "version=2"], packet_txt_read()) ||
-       die "bad version";
-packet_compare_lists([1, ""], packet_bin_read()) ||
-       die "bad version end";
-
-packet_txt_write("git-filter-server");
-packet_txt_write("version=2");
-packet_flush();
+packet_initialize("git-filter", 2);
 
 packet_compare_lists([0, "capability=clean"], packet_txt_read()) ||
        die "bad capability";