Andrew's git
/
gitweb.git
/ diff
summary
|
log
|
commit
| diff |
tree
commit
grep
author
committer
pickaxe
?
re
send-email: drop noise comments which merely repeat what code says
author
Eric Sunshine
<sunshine@sunshineco.com>
Sun, 31 May 2015 22:29:25 +0000
(18:29 -0400)
committer
Junio C Hamano
<gitster@pobox.com>
Mon, 1 Jun 2015 22:52:42 +0000
(15:52 -0700)
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
git-send-email.perl
patch
|
blob
|
history
raw
|
patch
|
inline
| side by side (parent:
818a2d7
)
diff --git
a/git-send-email.perl
b/git-send-email.perl
index 819f87e8df2435ed2c467e9109834d8993b5e923..0b1868200bcd3e756aecd41d43315d1525980ab1 100755
(executable)
--- a/
git-send-email.perl
+++ b/
git-send-email.perl
@@
-517,26
+517,21
@@
sub split_addrs {
} },
sendmail => sub { my $fh = shift; while (<$fh>) {
} },
sendmail => sub { my $fh = shift; while (<$fh>) {
- # ignore blank lines and comment lines
if (/^\s*(?:#.*)?$/) { }
if (/^\s*(?:#.*)?$/) { }
- # warn on lines that contain quotes
elsif (/"/) {
print STDERR "warning: sendmail alias with quotes is not supported: $_\n";
}
elsif (/"/) {
print STDERR "warning: sendmail alias with quotes is not supported: $_\n";
}
- # warn on lines that continue
elsif (/^\s|\\$/) {
print STDERR "warning: sendmail continuation line is not supported: $_\n";
}
elsif (/^\s|\\$/) {
print STDERR "warning: sendmail continuation line is not supported: $_\n";
}
- # recognize lines that look like an alias
elsif (/^(\S+?)\s*:\s*(.+)$/) {
my ($alias, $addr) = ($1, $2);
$aliases{$alias} = [ split_addrs($addr) ];
}
elsif (/^(\S+?)\s*:\s*(.+)$/) {
my ($alias, $addr) = ($1, $2);
$aliases{$alias} = [ split_addrs($addr) ];
}
- # warn on lines that are not recognized
else {
print STDERR "warning: sendmail line is not recognized: $_\n";
}}},
else {
print STDERR "warning: sendmail line is not recognized: $_\n";
}}},