ref-filter: mark a file-local symbol as static
authorRamsay Jones <ramsay@ramsayjones.plus.com>
Fri, 2 Mar 2018 02:54:02 +0000 (02:54 +0000)
committerJunio C Hamano <gitster@pobox.com>
Fri, 2 Mar 2018 17:17:26 +0000 (09:17 -0800)
Commit fcfba37337 ('ref-filter: make "--contains <id>" less chatty if
<id> is invalid', 2018-02-23) added the add_str_to_commit_list()
function, which causes sparse to issue a "... not declared. Should it
be static?" warning for that symbol.

Indeed, the function is only used in this one compilation unit. Mark
it static.

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
ref-filter.c
index aa282a27f4d996ea2c6b9e7d7974314258e773a2..ed993d32d8aa9319a98f4e821d21d9dea38e1607 100644 (file)
@@ -2000,7 +2000,7 @@ static void do_merge_filter(struct ref_filter_cbdata *ref_cbdata)
        free(to_clear);
 }
 
-int add_str_to_commit_list(struct string_list_item *item, void *commit_list)
+static int add_str_to_commit_list(struct string_list_item *item, void *commit_list)
 {
        struct object_id oid;
        struct commit *commit;