Merge branch 'jk/tighten-alloc'
authorJunio C Hamano <gitster@pobox.com>
Wed, 17 Aug 2016 21:07:46 +0000 (14:07 -0700)
committerJunio C Hamano <gitster@pobox.com>
Wed, 17 Aug 2016 21:07:46 +0000 (14:07 -0700)
Small code and comment clean-up.

* jk/tighten-alloc:
receive-pack: use FLEX_ALLOC_MEM in queue_command()
correct FLEXPTR_* example in comment

builtin/receive-pack.c
git-compat-util.h
index 92e1213ecc05969f4601c7d3c48f6d96dcf72a0a..011db00d31709408a21b97abfb5742b97b54238d 100644 (file)
@@ -1478,11 +1478,9 @@ static struct command **queue_command(struct command **tail,
 
        refname = line + 82;
        reflen = linelen - 82;
-       cmd = xcalloc(1, st_add3(sizeof(struct command), reflen, 1));
+       FLEX_ALLOC_MEM(cmd, ref_name, refname, reflen);
        hashcpy(cmd->old_sha1, old_sha1);
        hashcpy(cmd->new_sha1, new_sha1);
-       memcpy(cmd->ref_name, refname, reflen);
-       cmd->ref_name[reflen] = '\0';
        *tail = cmd;
        return &cmd->next;
 }
index 590bfddf73238d37f7b2d831a6e46ed608c005ce..f52e00b58057c7bfe040e516835a42d117be1de2 100644 (file)
@@ -815,7 +815,7 @@ extern FILE *fopen_for_writing(const char *path);
  * you can do:
  *
  *   struct foo *f;
- *   FLEX_ALLOC_STR(f, name, src);
+ *   FLEXPTR_ALLOC_STR(f, name, src);
  *
  * and "name" will point to a block of memory after the struct, which will be
  * freed along with the struct (but the pointer can be repointed anywhere).