Andrew's git
/
gitweb.git
/ diff
summary
|
log
|
commit
| diff |
tree
commit
grep
author
committer
pickaxe
?
re
git-commit.sh: Fix usage checks regarding paths given when they do not make sense
author
Björn Steinbrink
<B.Steinbrink@gmx.de>
Mon, 5 Nov 2007 19:36:33 +0000
(20:36 +0100)
committer
Junio C Hamano
<gitster@pobox.com>
Tue, 6 Nov 2007 05:36:31 +0000
(21:36 -0800)
The checks that looked for paths given to git-commit in addition to
--all or --interactive expected only 3 values, while the case statement
actually provides 4, so the check was never triggered.
The bug was introduced in
6cbf07efc5702351897dee4742525c9b9f7828ac
when
the case statement was extended to handle --interactive.
Signed-off-by: Björn Steinbrink <B.Steinbrink@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
git-commit.sh
patch
|
blob
|
history
raw
|
patch
| inline |
side by side
(parent:
d8e21ba
)
diff --git
a/git-commit.sh
b/git-commit.sh
index ab43217be4b49ce71ffee461569e0e4b395dfb5d..5e3908f2cbf5cf96b4f5c3b07d5178b3e2321b58 100755
(executable)
--- a/
git-commit.sh
+++ b/
git-commit.sh
@@
-322,9
+322,9
@@
unset only
case "$all,$interactive,$also,$#" in
*t,*t,*)
die "Cannot use -a, --interactive or -i at the same time." ;;
-t,,[1-9]*)
+t,,
,
[1-9]*)
die "Paths with -a does not make sense." ;;
-,t,[1-9]*)
+,t,
,
[1-9]*)
die "Paths with --interactive does not make sense." ;;
,,t,0)
die "No paths with -i does not make sense." ;;