Andrew's git / gitweb.git / diff
?
git-p4: Change p4 command invocation
authorPete Wyckoff <pw@padd.com>
Wed, 25 Jan 2012 23:48:24 +0000 (23:48 +0000)
committerJunio C Hamano <gitster@pobox.com>
Thu, 26 Jan 2012 19:35:40 +0000 (11:35 -0800)
Change p4 command invocation to avoid going through the shell. This
allows names with spaces and wildcards to work.

Signed-off-by: Pete Wyckoff <pw@padd.com>
Signed-off-by: Vitor Antunes <vitor.hda@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
contrib/fast-import/git-p4 patch | blob | history
diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
index 0bf2625077b2b25fbeebd0d77874a9e5e3f1a6ca..b951ce58bbc199a122f806377fd42563118969e5 100755 (executable)
--- a/contrib/fast-import/git-p4
+++ b/contrib/fast-import/git-p4
@@ -1984,7 +1984,7 @@ class P4Sync(Command, P4UserMap):
     def importChanges(self, changes):
         cnt = 1
         for change in changes:
-            description = p4Cmd("describe %s" % change)
+            description = p4Cmd(["describe", str(change)])
             self.updateOptionDict(description)
 
             if not self.silent: