git-svn: correctly handle "(no author)" when using an authors file
authorEric Wong <normalperson@yhbt.net>
Tue, 12 Dec 2006 04:25:58 +0000 (20:25 -0800)
committerJunio C Hamano <junkio@cox.net>
Wed, 13 Dec 2006 20:08:01 +0000 (12:08 -0800)
The low-level parts of the SVN library return NULL/undef for
author-less revisions, whereas "(no author)" is a (svn) client
convention.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
git-svn.perl
index 15254e479595de047258188e0979bea322869696..ec92b440b9b3041811b20adc40b843b1ed759e2a 100755 (executable)
@@ -2981,7 +2981,8 @@ sub libsvn_log_entry {
        my ($Y,$m,$d,$H,$M,$S) = ($date =~ /^(\d{4})\-(\d\d)\-(\d\d)T
                                         (\d\d)\:(\d\d)\:(\d\d).\d+Z$/x)
                                or die "Unable to parse date: $date\n";
-       if (defined $_authors && ! defined $users{$author}) {
+       if (defined $author && length $author > 0 &&
+           defined $_authors && ! defined $users{$author}) {
                die "Author: $author not defined in $_authors file\n";
        }
        $msg = '' if ($rev == 0 && !defined $msg);