pack-bitmap: switch hash tables to use struct object_id

Instead of storing unsigned char pointers in the hash tables, switch to
storing instances of struct object_id. Update several internal functions
and one external function to take pointers to struct object_id.

Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index a154fc29f6b7841c2417ca302b631437e7376baa..2d9a3bdc9d83e24759b5a8892c26863bd9829c34 100644 (file)
--- a/builtin/pack-objects.c
+++ b/builtin/pack-objects.c
@@ -1487,6 +1487,7 @@ static int can_reuse_delta(const unsigned char *base_sha1,
                           struct object_entry **base_out)
 {
        struct object_entry *base;
                           struct object_entry **base_out)
 {
        struct object_entry *base;

+       struct object_id base_oid;

 
        if (!base_sha1)
                return 0;
 
        if (!base_sha1)
                return 0;


@@ -1508,10 +1509,9 @@ static int can_reuse_delta(const unsigned char *base_sha1,
         * even if it was buried too deep in history to make it into the
         * packing list.
         */
         * even if it was buried too deep in history to make it into the
         * packing list.
         */

-       if (thin && bitmap_has_sha1_in_uninteresting(bitmap_git, base_sha1)) {
+       oidread(&base_oid, base_sha1);
+       if (thin && bitmap_has_oid_in_uninteresting(bitmap_git, &base_oid)) {

                if (use_delta_islands) {
                if (use_delta_islands) {

-                       struct object_id base_oid;
-                       hashcpy(base_oid.hash, base_sha1);

                        if (!in_same_island(&delta->idx.oid, &base_oid))
                                return 0;
                }
                        if (!in_same_island(&delta->idx.oid, &base_oid))
                                return 0;
                }

diff --git a/pack-bitmap.c b/pack-bitmap.c
index 603492c23780ef05d2c4eea425bc8938c4aa8b46..70d51f4f50087047e51cb43d140d232609d170ac 100644 (file)
--- a/pack-bitmap.c
+++ b/pack-bitmap.c
@@ -60,8 +60,8 @@ struct bitmap_index {
        struct ewah_bitmap *blobs;
        struct ewah_bitmap *tags;
 
        struct ewah_bitmap *blobs;
        struct ewah_bitmap *tags;
 

-       /* Map from SHA1 -> `stored_bitmap` for all the bitmapped commits */
-       khash_sha1 *bitmaps;
+       /* Map from object ID -> `stored_bitmap` for all the bitmapped commits */
+       kh_oid_map_t *bitmaps;

 
        /* Number of bitmapped commits */
        uint32_t entry_count;
 
        /* Number of bitmapped commits */
        uint32_t entry_count;


@@ -80,7 +80,7 @@ struct bitmap_index {
                struct object **objects;
                uint32_t *hashes;
                uint32_t count, alloc;
                struct object **objects;
                uint32_t *hashes;
                uint32_t count, alloc;

-               khash_sha1_pos *positions;
+               kh_oid_pos_t *positions;

        } ext_index;
 
        /* Bitmap result of the last performed walk */
        } ext_index;
 
        /* Bitmap result of the last performed walk */


@@ -183,7 +183,7 @@ static struct stored_bitmap *store_bitmap(struct bitmap_index *index,
        stored->flags = flags;
        oidread(&stored->oid, hash);
 
        stored->flags = flags;
        oidread(&stored->oid, hash);
 

-       hash_pos = kh_put_sha1(index->bitmaps, stored->oid.hash, &ret);
+       hash_pos = kh_put_oid_map(index->bitmaps, stored->oid, &ret);

 
        /* a 0 return code means the insertion succeeded with no changes,
         * because the SHA1 already existed on the map. this is bad, there
 
        /* a 0 return code means the insertion succeeded with no changes,
         * because the SHA1 already existed on the map. this is bad, there


@@ -306,8 +306,8 @@ static int load_pack_bitmap(struct bitmap_index *bitmap_git)
 {
        assert(bitmap_git->map);
 
 {
        assert(bitmap_git->map);
 

-       bitmap_git->bitmaps = kh_init_sha1();
-       bitmap_git->ext_index.positions = kh_init_sha1_pos();
+       bitmap_git->bitmaps = kh_init_oid_map();
+       bitmap_git->ext_index.positions = kh_init_oid_pos();

        load_pack_revindex(bitmap_git->pack);
 
        if (!(bitmap_git->commits = read_bitmap_1(bitmap_git)) ||
        load_pack_revindex(bitmap_git->pack);
 
        if (!(bitmap_git->commits = read_bitmap_1(bitmap_git)) ||


@@ -362,10 +362,10 @@ struct include_data {
 };
 
 static inline int bitmap_position_extended(struct bitmap_index *bitmap_git,
 };
 
 static inline int bitmap_position_extended(struct bitmap_index *bitmap_git,

-                                          const unsigned char *sha1)
+                                          const struct object_id *oid)

 {
 {

-       khash_sha1_pos *positions = bitmap_git->ext_index.positions;
-       khiter_t pos = kh_get_sha1_pos(positions, sha1);
+       khash_oid_pos *positions = bitmap_git->ext_index.positions;
+       khiter_t pos = kh_get_oid_pos(positions, *oid);

 
        if (pos < kh_end(positions)) {
                int bitmap_pos = kh_value(positions, pos);
 
        if (pos < kh_end(positions)) {
                int bitmap_pos = kh_value(positions, pos);


@@ -376,9 +376,9 @@ static inline int bitmap_position_extended(struct bitmap_index *bitmap_git,
 }
 
 static inline int bitmap_position_packfile(struct bitmap_index *bitmap_git,
 }
 
 static inline int bitmap_position_packfile(struct bitmap_index *bitmap_git,

-                                          const unsigned char *sha1)
+                                          const struct object_id *oid)

 {
 {

-       off_t offset = find_pack_entry_one(sha1, bitmap_git->pack);
+       off_t offset = find_pack_entry_one(oid->hash, bitmap_git->pack);

        if (!offset)
                return -1;
 
        if (!offset)
                return -1;
 


@@ -386,10 +386,10 @@ static inline int bitmap_position_packfile(struct bitmap_index *bitmap_git,
 }
 
 static int bitmap_position(struct bitmap_index *bitmap_git,
 }
 
 static int bitmap_position(struct bitmap_index *bitmap_git,

-                          const unsigned char *sha1)
+                          const struct object_id *oid)

 {
 {

-       int pos = bitmap_position_packfile(bitmap_git, sha1);
-       return (pos >= 0) ? pos : bitmap_position_extended(bitmap_git, sha1);
+       int pos = bitmap_position_packfile(bitmap_git, oid);
+       return (pos >= 0) ? pos : bitmap_position_extended(bitmap_git, oid);

 }
 
 static int ext_index_add_object(struct bitmap_index *bitmap_git,
 }
 
 static int ext_index_add_object(struct bitmap_index *bitmap_git,


@@ -401,7 +401,7 @@ static int ext_index_add_object(struct bitmap_index *bitmap_git,
        int hash_ret;
        int bitmap_pos;
 
        int hash_ret;
        int bitmap_pos;
 

-       hash_pos = kh_put_sha1_pos(eindex->positions, object->oid.hash, &hash_ret);
+       hash_pos = kh_put_oid_pos(eindex->positions, object->oid, &hash_ret);

        if (hash_ret > 0) {
                if (eindex->count >= eindex->alloc) {
                        eindex->alloc = (eindex->alloc + 16) * 3 / 2;
        if (hash_ret > 0) {
                if (eindex->count >= eindex->alloc) {
                        eindex->alloc = (eindex->alloc + 16) * 3 / 2;


@@ -431,7 +431,7 @@ static void show_object(struct object *object, const char *name, void *data_)
        struct bitmap_show_data *data = data_;
        int bitmap_pos;
 
        struct bitmap_show_data *data = data_;
        int bitmap_pos;
 

-       bitmap_pos = bitmap_position(data->bitmap_git, object->oid.hash);
+       bitmap_pos = bitmap_position(data->bitmap_git, &object->oid);

 
        if (bitmap_pos < 0)
                bitmap_pos = ext_index_add_object(data->bitmap_git, object,
 
        if (bitmap_pos < 0)
                bitmap_pos = ext_index_add_object(data->bitmap_git, object,


@@ -446,7 +446,7 @@ static void show_commit(struct commit *commit, void *data)
 
 static int add_to_include_set(struct bitmap_index *bitmap_git,
                              struct include_data *data,
 
 static int add_to_include_set(struct bitmap_index *bitmap_git,
                              struct include_data *data,

-                             const unsigned char *sha1,
+                             const struct object_id *oid,

                              int bitmap_pos)
 {
        khiter_t hash_pos;
                              int bitmap_pos)
 {
        khiter_t hash_pos;


@@ -457,7 +457,7 @@ static int add_to_include_set(struct bitmap_index *bitmap_git,
        if (bitmap_get(data->base, bitmap_pos))
                return 0;
 
        if (bitmap_get(data->base, bitmap_pos))
                return 0;
 

-       hash_pos = kh_get_sha1(bitmap_git->bitmaps, sha1);
+       hash_pos = kh_get_oid_map(bitmap_git->bitmaps, *oid);

        if (hash_pos < kh_end(bitmap_git->bitmaps)) {
                struct stored_bitmap *st = kh_value(bitmap_git->bitmaps, hash_pos);
                bitmap_or_ewah(data->base, lookup_stored_bitmap(st));
        if (hash_pos < kh_end(bitmap_git->bitmaps)) {
                struct stored_bitmap *st = kh_value(bitmap_git->bitmaps, hash_pos);
                bitmap_or_ewah(data->base, lookup_stored_bitmap(st));


@@ -473,13 +473,13 @@ static int should_include(struct commit *commit, void *_data)
        struct include_data *data = _data;
        int bitmap_pos;
 
        struct include_data *data = _data;
        int bitmap_pos;
 

-       bitmap_pos = bitmap_position(data->bitmap_git, commit->object.oid.hash);
+       bitmap_pos = bitmap_position(data->bitmap_git, &commit->object.oid);

        if (bitmap_pos < 0)
                bitmap_pos = ext_index_add_object(data->bitmap_git,
                                                  (struct object *)commit,
                                                  NULL);
 
        if (bitmap_pos < 0)
                bitmap_pos = ext_index_add_object(data->bitmap_git,
                                                  (struct object *)commit,
                                                  NULL);
 

-       if (!add_to_include_set(data->bitmap_git, data, commit->object.oid.hash,
+       if (!add_to_include_set(data->bitmap_git, data, &commit->object.oid,

                                bitmap_pos)) {
                struct commit_list *parent = commit->parents;
 
                                bitmap_pos)) {
                struct commit_list *parent = commit->parents;
 


@@ -517,7 +517,7 @@ static struct bitmap *find_objects(struct bitmap_index *bitmap_git,
                roots = roots->next;
 
                if (object->type == OBJ_COMMIT) {
                roots = roots->next;
 
                if (object->type == OBJ_COMMIT) {

-                       khiter_t pos = kh_get_sha1(bitmap_git->bitmaps, object->oid.hash);
+                       khiter_t pos = kh_get_oid_map(bitmap_git->bitmaps, object->oid);

 
                        if (pos < kh_end(bitmap_git->bitmaps)) {
                                struct stored_bitmap *st = kh_value(bitmap_git->bitmaps, pos);
 
                        if (pos < kh_end(bitmap_git->bitmaps)) {
                                struct stored_bitmap *st = kh_value(bitmap_git->bitmaps, pos);


@@ -559,7 +559,7 @@ static struct bitmap *find_objects(struct bitmap_index *bitmap_git,
                int pos;
 
                roots = roots->next;
                int pos;
 
                roots = roots->next;

-               pos = bitmap_position(bitmap_git, object->oid.hash);
+               pos = bitmap_position(bitmap_git, &object->oid);

 
                if (pos < 0 || base == NULL || !bitmap_get(base, pos)) {
                        object->flags &= ~UNINTERESTING;
 
                if (pos < 0 || base == NULL || !bitmap_get(base, pos)) {
                        object->flags &= ~UNINTERESTING;


@@ -925,7 +925,7 @@ static void test_show_object(struct object *object, const char *name,
        struct bitmap_test_data *tdata = data;
        int bitmap_pos;
 
        struct bitmap_test_data *tdata = data;
        int bitmap_pos;
 

-       bitmap_pos = bitmap_position(tdata->bitmap_git, object->oid.hash);
+       bitmap_pos = bitmap_position(tdata->bitmap_git, &object->oid);

        if (bitmap_pos < 0)
                die("Object not in bitmap: %s\n", oid_to_hex(&object->oid));
 
        if (bitmap_pos < 0)
                die("Object not in bitmap: %s\n", oid_to_hex(&object->oid));
 


@@ -939,7 +939,7 @@ static void test_show_commit(struct commit *commit, void *data)
        int bitmap_pos;
 
        bitmap_pos = bitmap_position(tdata->bitmap_git,
        int bitmap_pos;
 
        bitmap_pos = bitmap_position(tdata->bitmap_git,

-                                    commit->object.oid.hash);
+                                    &commit->object.oid);

        if (bitmap_pos < 0)
                die("Object not in bitmap: %s\n", oid_to_hex(&commit->object.oid));
 
        if (bitmap_pos < 0)
                die("Object not in bitmap: %s\n", oid_to_hex(&commit->object.oid));
 


@@ -966,7 +966,7 @@ void test_bitmap_walk(struct rev_info *revs)
                bitmap_git->version, bitmap_git->entry_count);
 
        root = revs->pending.objects[0].item;
                bitmap_git->version, bitmap_git->entry_count);
 
        root = revs->pending.objects[0].item;

-       pos = kh_get_sha1(bitmap_git->bitmaps, root->oid.hash);
+       pos = kh_get_oid_map(bitmap_git->bitmaps, root->oid);

 
        if (pos < kh_end(bitmap_git->bitmaps)) {
                struct stored_bitmap *st = kh_value(bitmap_git->bitmaps, pos);
 
        if (pos < kh_end(bitmap_git->bitmaps)) {
                struct stored_bitmap *st = kh_value(bitmap_git->bitmaps, pos);


@@ -1108,7 +1108,7 @@ void free_bitmap_index(struct bitmap_index *b)
        ewah_pool_free(b->trees);
        ewah_pool_free(b->blobs);
        ewah_pool_free(b->tags);
        ewah_pool_free(b->trees);
        ewah_pool_free(b->blobs);
        ewah_pool_free(b->tags);

-       kh_destroy_sha1(b->bitmaps);
+       kh_destroy_oid_map(b->bitmaps);

        free(b->ext_index.objects);
        free(b->ext_index.hashes);
        bitmap_free(b->result);
        free(b->ext_index.objects);
        free(b->ext_index.hashes);
        bitmap_free(b->result);


@@ -1116,8 +1116,8 @@ void free_bitmap_index(struct bitmap_index *b)
        free(b);
 }
 
        free(b);
 }
 

-int bitmap_has_sha1_in_uninteresting(struct bitmap_index *bitmap_git,
-                                    const unsigned char *sha1)
+int bitmap_has_oid_in_uninteresting(struct bitmap_index *bitmap_git,
+                                   const struct object_id *oid)

 {
        int pos;
 
 {
        int pos;
 


@@ -1126,7 +1126,7 @@ int bitmap_has_sha1_in_uninteresting(struct bitmap_index *bitmap_git,
        if (!bitmap_git->haves)
                return 0; /* walk had no "haves" */
 
        if (!bitmap_git->haves)
                return 0; /* walk had no "haves" */
 

-       pos = bitmap_position_packfile(bitmap_git, sha1);
+       pos = bitmap_position_packfile(bitmap_git, oid);

        if (pos < 0)
                return 0;
 
        if (pos < 0)
                return 0;
 

diff --git a/pack-bitmap.h b/pack-bitmap.h
index 344ba23af9b3b61ac01f211f707bb6cfe4223a4e..ee9792264c84c43b75fc4e8ffb66dd8c6e88bf1c 100644 (file)
--- a/pack-bitmap.h
+++ b/pack-bitmap.h
@@ -59,7 +59,7 @@ void free_bitmap_index(struct bitmap_index *);
  * queried to see if a particular object was reachable from any of the
  * objects flagged as UNINTERESTING.
  */
  * queried to see if a particular object was reachable from any of the
  * objects flagged as UNINTERESTING.
  */

-int bitmap_has_sha1_in_uninteresting(struct bitmap_index *, const unsigned char *sha1);
+int bitmap_has_oid_in_uninteresting(struct bitmap_index *, const struct object_id *oid);

 
 void bitmap_writer_show_progress(int show);
 void bitmap_writer_set_checksum(unsigned char *sha1);
 
 void bitmap_writer_show_progress(int show);
 void bitmap_writer_set_checksum(unsigned char *sha1);