git-p4: remove ticket expiry test

The git-p4 login ticket expiry test causes unreliable test
runs. Since the handling of ticket expiry in git-p4 is far
from polished anyway, let's remove it for now.

A better way to actually run the test is to create a python
"fake" version of "p4" which returns whatever expiry results
the test requires.

Ideally git-p4 would look at the expiry time before starting
any long operations, and cleanup gracefully if there is not
enough time left. But that's quite hard to do.

Signed-off-by: Luke Diamand <luke@diamand.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/t9833-errors.sh b/t/t9833-errors.sh
index 277d34701201af03d0efbcfe05336b6cfec5483b..47b312e1c9705af6f6ac6bb55ee81cb847f53d0c 100755 (executable)
--- a/t/t9833-errors.sh
+++ b/t/t9833-errors.sh
@@ -45,33 +45,6 @@ test_expect_success 'ticket logged out' '
        )
 '
 
-test_expect_success 'create group with short ticket expiry' '
-       P4TICKETS="$cli/tickets" &&
-       echo "newpassword" | p4 login &&
-       p4_add_user short_expiry_user &&
-       p4 -u short_expiry_user passwd -P password &&
-       p4 group -i <<-EOF &&
-       Group: testgroup
-       Timeout: 3
-       Users: short_expiry_user
-       EOF
-
-       p4 users | grep short_expiry_user
-'
-
-test_expect_success 'git operation with expired ticket' '
-       P4TICKETS="$cli/tickets" &&
-       P4USER=short_expiry_user &&
-       echo "password" | p4 login &&
-       (
-               cd "$git" &&
-               git p4 sync &&
-               sleep 5 &&
-               test_must_fail git p4 sync 2>errmsg &&
-               grep "failure accessing depot" errmsg
-       )
-'
-
 test_expect_success 'kill p4d' '
        kill_p4d
 '