builtin-merge: release the lockfile in try_merge_strategy()

Once we committed the locked index, we should release the lockfile. In
most cases this is done automatically when the process ends, but this is
not true in this case.

[jc: with additional tests from Eric Raible]

Signed-off-by: Miklos Vajna <vmiklos@frugalware.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/builtin-merge.c b/builtin-merge.c
index b857cf6246978846e0c19895fd6f66266cf6a6f4..bb09e6fb34f8552b959fa5dca5258ec69bc48c12 100644 (file)
--- a/builtin-merge.c
+++ b/builtin-merge.c
@@ -576,6 +576,7 @@ static int try_merge_strategy(const char *strategy, struct commit_list *common,
                                (write_cache(index_fd, active_cache, active_nr) ||
                                 commit_locked_index(lock)))
                        die ("unable to write %s", get_index_file());
                                (write_cache(index_fd, active_cache, active_nr) ||
                                 commit_locked_index(lock)))
                        die ("unable to write %s", get_index_file());

+               rollback_lock_file(lock);

                return clean ? 0 : 1;
        } else {
                args = xmalloc((4 + commit_list_count(common) +
                return clean ? 0 : 1;
        } else {
                args = xmalloc((4 + commit_list_count(common) +

diff --git a/t/t6026-merge-attr.sh b/t/t6026-merge-attr.sh
index 56fc34176859b81137b4d88af90398b9a74a18f7..86f47ca595c2d71e132c8acdbf7d8edadc1e0ecf 100755 (executable)
--- a/t/t6026-merge-attr.sh
+++ b/t/t6026-merge-attr.sh
@@ -142,4 +142,26 @@ test_expect_success 'custom merge backend' '
        rm -f $o $a $b
 '
 
        rm -f $o $a $b
 '
 

+test_expect_success 'up-to-date merge without common ancestor' '
+       test_create_repo repo1 &&
+       test_create_repo repo2 &&
+       test_tick &&
+       (
+               cd repo1 &&
+               >a &&
+               git add a &&
+               git commit -m initial
+       ) &&
+       test_tick &&
+       (
+               cd repo2 &&
+               git commit --allow-empty -m initial
+       ) &&
+       test_tick &&
+       (
+               cd repo1 &&
+               git pull ../repo2 master
+       )
+'
+

 test_done
 test_done