checkout: fix memory leak
authorJunio C Hamano <gitster@pobox.com>
Mon, 8 May 2017 04:21:06 +0000 (13:21 +0900)
committerJunio C Hamano <gitster@pobox.com>
Wed, 10 May 2017 04:12:15 +0000 (21:12 -0700)
When "git checkout -m" does an in-core three-way merge to carry
local modifications forward to check out a different branch, the
code forgot to free the updated contents it has in-core.

Noticed-by: René Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/checkout.c
index 5faea3a05fa620e490a71793a474e0284a9043bb..94849cf250ebcf35efe17c120205359d91ae7648 100644 (file)
@@ -247,6 +247,7 @@ static int checkout_merged(int pos, const struct checkout *state)
        if (write_sha1_file(result_buf.ptr, result_buf.size,
                            blob_type, oid.hash))
                die(_("Unable to add merge result for '%s'"), path);
+       free(result_buf.ptr);
        ce = make_cache_entry(mode, oid.hash, path, 2, 0);
        if (!ce)
                die(_("make_cache_entry failed for path '%s'"), path);