t4211: retire soon-to-be unimplementable tests
authorEric Sunshine <sunshine@sunshineco.com>
Wed, 31 Jul 2013 08:15:40 +0000 (04:15 -0400)
committerJunio C Hamano <gitster@pobox.com>
Mon, 5 Aug 2013 18:54:31 +0000 (11:54 -0700)
58960978 and 99780b0a added tests which demonstrated bugs (crashes) in
range-set and line-log when handed empty ranges specified via "log
-LX:file" where X is one greater than the last line of the file. After
these tests were added, it was realized that the ability to specify an
empty range is a loophole due to a bug in -L bounds checking. That bug
is slated to be fixed in a subsequent patch.

Unfortunately, the closure of this loophole makes it impossible to
continue checking range-set and line-log behavior with regard to empty
ranges since there is no other way to specify empty ranges via the
command-line. APIs of both facilities are private (file static) so
there likewise is no way to test their behaviors programmatically.
Consequently, retire these two tests.

Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t4211-line-log.sh
index f98275c37cb261deea5aebaf44257e8da44fada2..769ac686c388d9378a273c05e34642410c3566a3 100755 (executable)
@@ -94,17 +94,4 @@ test_expect_success '-L ,Y (Y == nlines + 2)' '
        test_must_fail git log -L ,$n:b.c
 '
 
-# There is a separate bug when an empty -L range is the first -L encountered,
-# thus to demonstrate this particular bug, the empty -L range must follow a
-# non-empty -L range.
-test_expect_success '-L {empty-range} (any -L)' '
-       n=$(expr $(wc -l <b.c) + 1) &&
-       git log -L1,1:b.c -L$n:b.c
-'
-
-test_expect_success '-L {empty-range} (first -L)' '
-       n=$(expr $(wc -l <b.c) + 1) &&
-       git log -L$n:b.c
-'
-
 test_done