t1450: fix testcases that were wrongly expecting failure

Almost exactly a year ago in 02a6552 (Test fsck a bit harder), I
introduced two testcases that were expecting failure.

However, the only bug was that the testcases wrote *blobs* because I
forgot to pass -t tag to hash-object.  Fix this, and then adjust the
rest of the test to properly check the result.

Signed-off-by: Thomas Rast <trast@student.ethz.ch>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh
index a22632f483e2068642aa09a5bc28fde01d2294b9..49cae3ed524d70ae39114b35a95e7070f1a4e575 100755 (executable)
--- a/t/t1450-fsck.sh
+++ b/t/t1450-fsck.sh
@@ -66,12 +66,12 @@ tagger T A Gger <tagger@example.com> 1234567890 -0000
 This is an invalid tag.
 EOF
 
 This is an invalid tag.
 EOF
 

-test_expect_failure 'tag pointing to nonexistent' '
-       tag=$(git hash-object -w --stdin < invalid-tag) &&
+test_expect_success 'tag pointing to nonexistent' '
+       tag=$(git hash-object -t tag -w --stdin < invalid-tag) &&

        echo $tag > .git/refs/tags/invalid &&
        echo $tag > .git/refs/tags/invalid &&

-       git fsck --tags 2>out &&
+       test_must_fail git fsck --tags >out &&

        cat out &&
        cat out &&

-       grep "could not load tagged object" out &&
+       grep "broken link" out &&

        rm .git/refs/tags/invalid
 '
 
        rm .git/refs/tags/invalid
 '
 


@@ -84,12 +84,12 @@ tagger T A Gger <tagger@example.com> 1234567890 -0000
 This is an invalid tag.
 EOF
 
 This is an invalid tag.
 EOF
 

-test_expect_failure 'tag pointing to something else than its type' '
-       tag=$(git hash-object -w --stdin < wrong-tag) &&
+test_expect_success 'tag pointing to something else than its type' '
+       tag=$(git hash-object -t tag -w --stdin < wrong-tag) &&

        echo $tag > .git/refs/tags/wrong &&
        echo $tag > .git/refs/tags/wrong &&

-       git fsck --tags 2>out &&
+       test_must_fail git fsck --tags 2>out &&

        cat out &&
        cat out &&

-       grep "some sane error message" out &&
+       grep "error in tag.*broken links" out &&

        rm .git/refs/tags/wrong
 '
 
        rm .git/refs/tags/wrong
 '