tag: remove a TODO item from the test suite
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Thu, 23 Mar 2017 13:05:19 +0000 (13:05 +0000)
committerJunio C Hamano <gitster@pobox.com>
Thu, 23 Mar 2017 17:02:55 +0000 (10:02 -0700)
Change the test for "git tag -l" to not have an associated TODO
comment saying that it should return non-zero if there's no tags.

This was added in commit ef5a6fb597 ("Add test-script for git-tag",
2007-06-28) when the tests for "tag" were initially added, but at this
point changing this would be inconsistent with how "git tag" is a
synonym for "git tag -l", and would needlessly break external code
that relies on this porcelain command.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t7004-tag.sh
index 3439913488d19fbdf13bd4ea2150a037317e7825..830eff948ece1cdf5b27348fe6cb281ce40b2348 100755 (executable)
@@ -16,7 +16,6 @@ tag_exists () {
        git show-ref --quiet --verify refs/tags/"$1"
 }
 
-# todo: git tag -l now returns always zero, when fixed, change this test
 test_expect_success 'listing all tags in an empty tree should succeed' '
        git tag -l &&
        git tag
@@ -136,7 +135,6 @@ test_expect_success \
        'listing a tag using a matching pattern should output that tag' \
        'test $(git tag -l mytag) = mytag'
 
-# todo: git tag -l now returns always zero, when fixed, change this test
 test_expect_success \
        'listing tags using a non-matching pattern should suceed' \
        'git tag -l xxx'