cvsserver: use safe_pipe_capture for `constant commands` as well

This is not strictly necessary, but it is a good code hygiene.

Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/git-cvsserver.perl b/git-cvsserver.perl
index bd29b26cc285568df5eec1ce831a75b3ca985fd6..ae1044273d01125af96a06f1d68cbbd3d0e25c41 100755 (executable)
--- a/git-cvsserver.perl
+++ b/git-cvsserver.perl
@@ -356,7 +356,7 @@ sub req_Root
        return 0;
     }
 
        return 0;
     }
 

-    my @gitvars = `git config -l`;
+    my @gitvars = safe_pipe_capture(qw(git config -l));

     if ($?) {
        print "E problems executing git-config on the server -- this is not a git repository or the PATH is not set correctly.\n";
         print "E \n";
     if ($?) {
        print "E problems executing git-config on the server -- this is not a git repository or the PATH is not set correctly.\n";
         print "E \n";


@@ -943,7 +943,7 @@ sub req_co
 
     # Provide list of modules, if -c was used.
     if (exists $state->{opt}{c}) {
 
     # Provide list of modules, if -c was used.
     if (exists $state->{opt}{c}) {

-        my $showref = `git show-ref --heads`;
+        my $showref = safe_pipe_capture(qw(git show-ref --heads));

         for my $line (split '\n', $showref) {
             if ( $line =~ m% refs/heads/(.*)$% ) {
                 print "M $1\t$1\n";
         for my $line (split '\n', $showref) {
             if ( $line =~ m% refs/heads/(.*)$% ) {
                 print "M $1\t$1\n";


@@ -1181,7 +1181,7 @@ sub req_update
     # projects (heads in this case) to checkout.
     #
     if ($state->{module} eq '') {
     # projects (heads in this case) to checkout.
     #
     if ($state->{module} eq '') {

-        my $showref = `git show-ref --heads`;
+        my $showref = safe_pipe_capture(qw(git show-ref --heads));

         print "E cvs update: Updating .\n";
         for my $line (split '\n', $showref) {
             if ( $line =~ m% refs/heads/(.*)$% ) {
         print "E cvs update: Updating .\n";
         for my $line (split '\n', $showref) {
             if ( $line =~ m% refs/heads/(.*)$% ) {


@@ -1687,7 +1687,7 @@ sub req_ci
         return;
     }
 
         return;
     }
 

-    my $treehash = `git write-tree`;
+    my $treehash = safe_pipe_capture(qw(git write-tree));

     chomp $treehash;
 
     $log->debug("Treehash : $treehash, Parenthash : $parenthash");
     chomp $treehash;
 
     $log->debug("Treehash : $treehash, Parenthash : $parenthash");