filter-branch: update current branch when rewritten

Earlier, "git filter-branch --<options> HEAD" would not update the
working tree after rewriting the branch.  This commit fixes it.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>

diff --git a/git-filter-branch.sh b/git-filter-branch.sh
index a12f6c2d4c7ad3c4f69a783f7255b3010224d0c3..ffcc408ee5217d7a8f6179a0404ffe387e0dab0f 100755 (executable)
--- a/git-filter-branch.sh
+++ b/git-filter-branch.sh
@@ -94,6 +94,10 @@ USAGE="[--env-filter <command>] [--tree-filter <command>] \
 
 . git-sh-setup
 
 
 . git-sh-setup
 

+git diff-files --quiet &&
+       git diff-index --cached --quiet HEAD ||
+       die "Cannot rewrite branch(es) with a dirty working directory."
+

 tempdir=.git-rewrite
 filter_env=
 filter_tree=
 tempdir=.git-rewrite
 filter_env=
 filter_tree=


@@ -196,6 +200,9 @@ do
        esac
 done < "$tempdir"/backup-refs
 
        esac
 done < "$tempdir"/backup-refs
 

+ORIG_GIT_DIR="$GIT_DIR"
+ORIG_GIT_WORK_TREE="$GIT_WORK_TREE"
+ORIG_GIT_INDEX_FILE="$GIT_INDEX_FILE"

 export GIT_DIR GIT_WORK_TREE=.
 
 # These refs should be updated if their heads were rewritten
 export GIT_DIR GIT_WORK_TREE=.
 
 # These refs should be updated if their heads were rewritten


@@ -413,4 +420,12 @@ echo
 test $count -gt 0 && echo "These refs were rewritten:"
 git show-ref | grep ^"$orig_namespace"
 
 test $count -gt 0 && echo "These refs were rewritten:"
 git show-ref | grep ^"$orig_namespace"
 

+unset GIT_DIR GIT_WORK_TREE GIT_INDEX_FILE
+test -z "$ORIG_GIT_DIR" || GIT_DIR="$ORIG_GIT_DIR" && export GIT_DIR
+test -z "$ORIG_GIT_WORK_TREE" || GIT_WORK_TREE="$ORIG_GIT_WORK_TREE" &&
+       export GIT_WORK_TREE
+test -z "$ORIG_GIT_INDEX_FILE" || GIT_INDEX_FILE="$ORIG_GIT_INDEX_FILE" &&
+       export GIT_INDEX_FILE
+git read-tree -u -m HEAD
+

 exit $ret
 exit $ret

diff --git a/t/t7003-filter-branch.sh b/t/t7003-filter-branch.sh
index e935b2000ac6589a4940f585616f8bf3be95223b..2089351f7d157ce96a07ed1c6c1465fc58819ec0 100755 (executable)
--- a/t/t7003-filter-branch.sh
+++ b/t/t7003-filter-branch.sh
@@ -41,7 +41,9 @@ test_expect_success 'rewrite, renaming a specific file' '
 '
 
 test_expect_success 'test that the file was renamed' '
 '
 
 test_expect_success 'test that the file was renamed' '

-       test d = $(git show HEAD:doh)
+       test d = $(git show HEAD:doh) &&
+       test -f doh &&
+       test d = $(cat doh)

 '
 
 git tag oldD HEAD~4
 '
 
 git tag oldD HEAD~4