Andrew's git
/
gitweb.git
/ diff
summary
|
log
|
commit
| diff |
tree
commit
grep
author
committer
pickaxe
?
re
diff: use HAS_MULTI_BITS instead of counting bits manually
author
Stefan Beller
<sbeller@google.com>
Thu, 4 Jan 2018 22:50:44 +0000
(14:50 -0800)
committer
Junio C Hamano
<gitster@pobox.com>
Thu, 4 Jan 2018 23:02:40 +0000
(15:02 -0800)
This aligns the style to the previous patch.
Signed-off-by: Stefan Beller <sbeller@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff.c
patch
|
blob
|
history
raw
|
patch
|
inline
| side by side (parent:
5e50525
)
diff --git
a/diff.c
b/diff.c
index 42858d4c7d058b876b0279bdefdb23850e8532ad..c2ee81a1fa4dfeaf40f558606639456815ff5d84 100644
(file)
--- a/
diff.c
+++ b/
diff.c
@@
-4107,20
+4107,15
@@
void diff_setup(struct diff_options *options)
void diff_setup_done(struct diff_options *options)
{
void diff_setup_done(struct diff_options *options)
{
- int count = 0;
+ unsigned check_mask = DIFF_FORMAT_NAME |
+ DIFF_FORMAT_NAME_STATUS |
+ DIFF_FORMAT_CHECKDIFF |
+ DIFF_FORMAT_NO_OUTPUT;
if (options->set_default)
options->set_default(options);
if (options->set_default)
options->set_default(options);
- if (options->output_format & DIFF_FORMAT_NAME)
- count++;
- if (options->output_format & DIFF_FORMAT_NAME_STATUS)
- count++;
- if (options->output_format & DIFF_FORMAT_CHECKDIFF)
- count++;
- if (options->output_format & DIFF_FORMAT_NO_OUTPUT)
- count++;
- if (count > 1)
+ if (HAS_MULTI_BITS(options->output_format & check_mask))
die(_("--name-only, --name-status, --check and -s are mutually exclusive"));
if (HAS_MULTI_BITS(options->pickaxe_opts & DIFF_PICKAXE_KINDS_MASK))
die(_("--name-only, --name-status, --check and -s are mutually exclusive"));
if (HAS_MULTI_BITS(options->pickaxe_opts & DIFF_PICKAXE_KINDS_MASK))