t6050-replace: don't disable stdin for the whole test script
authorSZEDER Gábor <szeder.dev@gmail.com>
Mon, 7 May 2018 12:04:07 +0000 (14:04 +0200)
committerJunio C Hamano <gitster@pobox.com>
Wed, 9 May 2018 02:21:53 +0000 (11:21 +0900)
The test script 't6050-replace.sh' starts off with redirecting the
whole test script's stdin from /dev/null. This redirection has been
there since the test script was introduced in a3e8267225
(replace_object: add a test case, 2009-01-23), but the commit message
doesn't explain why it was deemed necessary. AFAICT, it has never
been necessary, and t6050 runs just fine and succeeds even without it,
not only the current version but past versions as well.

Besides being unnecessary, this redirection is also harmful, as it
prevents the test helper functions 'test_pause' and 'debug' from
working properly in t6050, because we can't enter any commands to the
shell and the debugger, respectively.

So let's remove that redirection.

Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t6050-replace.sh
index c630aba657e9c78b6dee4a72be34ed3bd03c01ee..199fbc78a39f8d3646e700dd28480e19f49ea5db 100755 (executable)
@@ -4,8 +4,6 @@
 #
 test_description='Tests replace refs functionality'
 
 #
 test_description='Tests replace refs functionality'
 
-exec </dev/null
-
 . ./test-lib.sh
 . "$TEST_DIRECTORY/lib-gpg.sh"
 
 . ./test-lib.sh
 . "$TEST_DIRECTORY/lib-gpg.sh"