remote-bzr: fix cloning of non-listable repos
authorFelipe Contreras <felipe.contreras@gmail.com>
Thu, 16 May 2013 10:04:05 +0000 (05:04 -0500)
committerJunio C Hamano <gitster@pobox.com>
Thu, 16 May 2013 16:29:26 +0000 (09:29 -0700)
Commit 95b0c60 (remote-bzr: add support for bzr repos) introduced a
regression by assuming all bzr remote repos are listable, but they are
not.

If they are not listable they are basically useless, so let's assume
there is no bzr repo.

Reported-by: Thorsten Kranzkowski <dl8bcu@dl8bcu.de>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
contrib/remote-helpers/git-remote-bzr
index b295dd489531f23bbaae5c07eeed6e94c2a9aa4c..ad42317ca095c960f5a8d87aee768d9690ef6eaa 100755 (executable)
@@ -840,6 +840,9 @@ def get_repo(url, alias):
 
     try:
         repo = origin.open_repository()
+        if not repo.user_transport.listable():
+            # this repository is not usable for us
+            raise bzrlib.errors.NoRepositoryPresent(repo.bzrdir)
     except bzrlib.errors.NoRepositoryPresent:
         # branch