Merge branch 'jc/commit-tree-ignore-commit-gpgsign'
authorJunio C Hamano <gitster@pobox.com>
Fri, 13 May 2016 20:18:27 +0000 (13:18 -0700)
committerJunio C Hamano <gitster@pobox.com>
Fri, 13 May 2016 20:18:27 +0000 (13:18 -0700)
"git commit-tree" plumbing command required the user to always sign
its result when the user sets the commit.gpgsign configuration
variable, which was an ancient mistake. Rework "git rebase" that
relied on this mistake so that it reads commit.gpgsign and pass (or
not pass) the -S option to "git commit-tree" to keep the end-user
expectation the same, while teaching "git commit-tree" to ignore
the configuration variable. This will stop requiring the users to
sign commit objects used internally as an implementation detail of
"git stash".

* jc/commit-tree-ignore-commit-gpgsign:
commit-tree: do not pay attention to commit.gpgsign

1  2 
Documentation/git-commit-tree.txt
builtin/commit-tree.c
git-rebase.sh
t/t7510-signed-commit.sh
index 48c33d7ed7323c7fc4776ffeb98aad9b41b23744,eb273c3d8a0972fb32cdb9c61949e2b3f0e0953c..cb69faab686285050d121b1bd64f509a0b561f3e
@@@ -56,13 -56,11 +56,13 @@@ OPTION
  
  -S[<keyid>]::
  --gpg-sign[=<keyid>]::
 -      GPG-sign commit.
 +      GPG-sign commits. The `keyid` argument is optional and
 +      defaults to the committer identity; if specified, it must be
 +      stuck to the option without a space.
  
  --no-gpg-sign::
-       Countermand `commit.gpgSign` configuration variable that is
-       set to force each and every commit to be signed.
+       Do not GPG-sign commit, to countermand a `--gpg-sign` option
+       given earlier on the command line.
  
  
  Commit Information
Simple merge
diff --cc git-rebase.sh
Simple merge
Simple merge