test-hg.sh: eliminate 'local' bashism
authorRichard Hansen <rhansen@bbn.com>
Mon, 18 Nov 2013 04:12:46 +0000 (23:12 -0500)
committerJunio C Hamano <gitster@pobox.com>
Mon, 18 Nov 2013 21:45:58 +0000 (13:45 -0800)
Unlike bash, POSIX shell does not specify a 'local' command for
declaring function-local variable scope. Except for IFS, the variable
names are not used anywhere else in the script so simply remove the
'local'. For IFS, move the assignment to the 'read' command to
prevent it from affecting code outside the function.

Signed-off-by: Richard Hansen <rhansen@bbn.com>
Reviewed-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
contrib/remote-helpers/test-hg.sh
index fa7d17b224b4746928fb3def60a4d4f7b608a9d1..ceef6b1917b746008f308fdd5e81358c019bfd4f 100755 (executable)
@@ -54,14 +54,14 @@ check_bookmark () {
 }
 
 check_push () {
-       local expected_ret=$1 ret=0 ref_ret=0 IFS=':'
+       expected_ret=$1 ret=0 ref_ret=0
 
        shift
        git push origin "$@" 2>error
        ret=$?
        cat error
 
-       while read branch kind
+       while IFS=':' read branch kind
        do
                case "$kind" in
                'new')