completion: show can take both revlist and paths
authorRamkumar Ramachandra <artagnon@gmail.com>
Sun, 2 Jun 2013 14:03:42 +0000 (19:33 +0530)
committerJunio C Hamano <gitster@pobox.com>
Sun, 9 Jun 2013 22:56:35 +0000 (15:56 -0700)
The 'git show' completion uses __git_complete_file (aliased to
__git_complete_revlist_file), because accepts <tree-ish>:<path> as
well as <commit-ish>. But the command also accepts range of commits
in A..B notation, so using __git_complete_revlist_file is more
appropriate.

There still remain two users of __git_complete_file, completions for
"archive" and "ls-tree". As these commands do not take range
notation, and "git show" no longer uses __git_complete_file, the
implementation of it can be updated not to complete ranges, but that
is a separate topic.

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
contrib/completion/git-completion.bash
index 1b4b0f95a9ab2f85581c963dcb055886f5302988..b9dfc3be7558be7ffc9a7116d02269085b19c1cd 100644 (file)
@@ -2360,7 +2360,7 @@ _git_show ()
                return
                ;;
        esac
-       __git_complete_file
+       __git_complete_revlist_file
 }
 
 _git_show_branch ()