rollback_lock_file(): do not clear filename redundantly
authorMichael Haggerty <mhagger@alum.mit.edu>
Wed, 1 Oct 2014 10:28:08 +0000 (12:28 +0200)
committerJunio C Hamano <gitster@pobox.com>
Wed, 1 Oct 2014 20:38:39 +0000 (13:38 -0700)
It is only necessary to clear the lock_file's filename field if it was
not already clear.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Reviewed-by: Ronnie Sahlberg <sahlberg@google.com>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
lockfile.c
index d02c3bf901560d1e2bb021b23de7aae24bb45c0d..5330d6ae52ad6693c77fa31d24a51f7448597d34 100644 (file)
@@ -280,6 +280,6 @@ void rollback_lock_file(struct lock_file *lk)
                if (lk->fd >= 0)
                        close(lk->fd);
                unlink_or_warn(lk->filename);
+               lk->filename[0] = 0;
        }
-       lk->filename[0] = 0;
 }