reflog-walk: tell explicit --date=default from not having --date at all

Introduction of opt->date_mode_explicit was a step in the right direction,
but lost that crucial bit at the very end of the callchain, and the callee
could not tell an explicitly specified "I want *date* but in default format"
from the built-in default value passed when there was no --date specified.

Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/log-tree.c b/log-tree.c
index 5f9e59a10cc697681c58eb8e2b6a31febb08e657..588117e013e4d6c4362cb67ec1e5bf1768b4ccb9 100644 (file)
--- a/log-tree.c
+++ b/log-tree.c
@@ -493,10 +493,9 @@ void show_log(struct rev_info *opt)
                         * graph info here.
                         */
                        show_reflog_message(opt->reflog_info,
                         * graph info here.
                         */
                        show_reflog_message(opt->reflog_info,

-                                   opt->commit_format == CMIT_FMT_ONELINE,
-                                   opt->date_mode_explicit ?
-                                       opt->date_mode :
-                                       DATE_NORMAL);
+                                           opt->commit_format == CMIT_FMT_ONELINE,
+                                           opt->date_mode,
+                                           opt->date_mode_explicit);

                        if (opt->commit_format == CMIT_FMT_ONELINE)
                                return;
                }
                        if (opt->commit_format == CMIT_FMT_ONELINE)
                                return;
                }

diff --git a/pretty.c b/pretty.c
index efd62e8ae7891f42910d49ed1c9538844721762c..25944de034e1b352a7264b5ae66bf8e201405880 100644 (file)
--- a/pretty.c
+++ b/pretty.c
@@ -956,9 +956,8 @@ static size_t format_commit_one(struct strbuf *sb, const char *placeholder,
                        if (c->pretty_ctx->reflog_info)
                                get_reflog_selector(sb,
                                                    c->pretty_ctx->reflog_info,
                        if (c->pretty_ctx->reflog_info)
                                get_reflog_selector(sb,
                                                    c->pretty_ctx->reflog_info,

-                                                   c->pretty_ctx->date_mode_explicit ?
-                                                     c->pretty_ctx->date_mode :
-                                                     DATE_NORMAL,
+                                                   c->pretty_ctx->date_mode,
+                                                   c->pretty_ctx->date_mode_explicit,

                                                    (placeholder[1] == 'd'));
                        return 2;
                case 's':       /* reflog message */
                                                    (placeholder[1] == 'd'));
                        return 2;
                case 's':       /* reflog message */

diff --git a/reflog-walk.c b/reflog-walk.c
index b84e80f2caafd5cb16ef7f99a84770fcaa3015ef..0c904fb2d1637f63b28a44caafd3d40e437266a9 100644 (file)
--- a/reflog-walk.c
+++ b/reflog-walk.c
@@ -252,7 +252,7 @@ void fake_reflog_parent(struct reflog_walk_info *info, struct commit *commit)
 
 void get_reflog_selector(struct strbuf *sb,
                         struct reflog_walk_info *reflog_info,
 
 void get_reflog_selector(struct strbuf *sb,
                         struct reflog_walk_info *reflog_info,

-                        enum date_mode dmode,
+                        enum date_mode dmode, int force_date,

                         int shorten)
 {
        struct commit_reflog *commit_reflog = reflog_info->last_commit_reflog;
                         int shorten)
 {
        struct commit_reflog *commit_reflog = reflog_info->last_commit_reflog;


@@ -273,7 +273,7 @@ void get_reflog_selector(struct strbuf *sb,
 
        strbuf_addf(sb, "%s@{", printed_ref);
        if (commit_reflog->selector == SELECTOR_DATE ||
 
        strbuf_addf(sb, "%s@{", printed_ref);
        if (commit_reflog->selector == SELECTOR_DATE ||

-           (commit_reflog->selector == SELECTOR_NONE && dmode)) {
+           (commit_reflog->selector == SELECTOR_NONE && force_date)) {

                info = &commit_reflog->reflogs->items[commit_reflog->recno+1];
                strbuf_addstr(sb, show_date(info->timestamp, info->tz, dmode));
        } else {
                info = &commit_reflog->reflogs->items[commit_reflog->recno+1];
                strbuf_addstr(sb, show_date(info->timestamp, info->tz, dmode));
        } else {


@@ -302,7 +302,7 @@ void get_reflog_message(struct strbuf *sb,
 }
 
 void show_reflog_message(struct reflog_walk_info *reflog_info, int oneline,
 }
 
 void show_reflog_message(struct reflog_walk_info *reflog_info, int oneline,

-       enum date_mode dmode)
+                        enum date_mode dmode, int force_date)

 {
        if (reflog_info && reflog_info->last_commit_reflog) {
                struct commit_reflog *commit_reflog = reflog_info->last_commit_reflog;
 {
        if (reflog_info && reflog_info->last_commit_reflog) {
                struct commit_reflog *commit_reflog = reflog_info->last_commit_reflog;


@@ -310,7 +310,7 @@ void show_reflog_message(struct reflog_walk_info *reflog_info, int oneline,
                struct strbuf selector = STRBUF_INIT;
 
                info = &commit_reflog->reflogs->items[commit_reflog->recno+1];
                struct strbuf selector = STRBUF_INIT;
 
                info = &commit_reflog->reflogs->items[commit_reflog->recno+1];

-               get_reflog_selector(&selector, reflog_info, dmode, 0);
+               get_reflog_selector(&selector, reflog_info, dmode, force_date, 0);

                if (oneline) {
                        printf("%s: %s", selector.buf, info->message);
                }
                if (oneline) {
                        printf("%s: %s", selector.buf, info->message);
                }

diff --git a/reflog-walk.h b/reflog-walk.h
index 7bd2cd4c4e5cd9d51e645509eeacc49a83a44ba7..3adccb018bd996c3222bdbc89843265d800a02b4 100644 (file)
--- a/reflog-walk.h
+++ b/reflog-walk.h
@@ -11,12 +11,12 @@ extern int add_reflog_for_walk(struct reflog_walk_info *info,
 extern void fake_reflog_parent(struct reflog_walk_info *info,
                struct commit *commit);
 extern void show_reflog_message(struct reflog_walk_info *info, int,
 extern void fake_reflog_parent(struct reflog_walk_info *info,
                struct commit *commit);
 extern void show_reflog_message(struct reflog_walk_info *info, int,

-               enum date_mode);
+                               enum date_mode, int force_date);

 extern void get_reflog_message(struct strbuf *sb,
                struct reflog_walk_info *reflog_info);
 extern void get_reflog_selector(struct strbuf *sb,
                struct reflog_walk_info *reflog_info,
 extern void get_reflog_message(struct strbuf *sb,
                struct reflog_walk_info *reflog_info);
 extern void get_reflog_selector(struct strbuf *sb,
                struct reflog_walk_info *reflog_info,

-               enum date_mode dmode,
+               enum date_mode dmode, int force_date,

                int shorten);
 
 #endif
                int shorten);
 
 #endif

diff --git a/t/t1411-reflog-show.sh b/t/t1411-reflog-show.sh
index 7d9b5e33dfc662e97b94116e28062293b8516a9e..9a105fe21f0da2851fc0f2aae4ff10e2417c9842 100755 (executable)
--- a/t/t1411-reflog-show.sh
+++ b/t/t1411-reflog-show.sh
@@ -73,20 +73,20 @@ test_expect_success 'using @{now} syntax shows reflog date (format=%gd)' '
 '
 
 cat >expect <<'EOF'
 '
 
 cat >expect <<'EOF'

-Reflog: HEAD@{1112911993 -0700} (C O Mitter <committer@example.com>)
+Reflog: HEAD@{Thu Apr 7 15:13:13 2005 -0700} (C O Mitter <committer@example.com>)

 Reflog message: commit (initial): one
 EOF
 test_expect_success 'using --date= shows reflog date (multiline)' '
 Reflog message: commit (initial): one
 EOF
 test_expect_success 'using --date= shows reflog date (multiline)' '

-       git log -g -1 --date=raw >tmp &&
+       git log -g -1 --date=default >tmp &&

        grep ^Reflog <tmp >actual &&
        test_cmp expect actual
 '
 
 cat >expect <<'EOF'
        grep ^Reflog <tmp >actual &&
        test_cmp expect actual
 '
 
 cat >expect <<'EOF'

-e46513e HEAD@{1112911993 -0700}: commit (initial): one
+e46513e HEAD@{Thu Apr 7 15:13:13 2005 -0700}: commit (initial): one

 EOF
 test_expect_success 'using --date= shows reflog date (oneline)' '
 EOF
 test_expect_success 'using --date= shows reflog date (oneline)' '

-       git log -g -1 --oneline --date=raw >actual &&
+       git log -g -1 --oneline --date=default >actual &&

        test_cmp expect actual
 '
 
        test_cmp expect actual
 '