t1309: use short branch name in includeIf.onbranch test
authorJeff King <peff@peff.net>
Tue, 6 Aug 2019 12:26:45 +0000 (08:26 -0400)
committerJunio C Hamano <gitster@pobox.com>
Tue, 6 Aug 2019 20:09:01 +0000 (13:09 -0700)
Commit 85fe0e800c (config: work around bug with includeif:onbranch and
early config, 2019-07-31) tests that our early config-reader does not
access the file mentioned by includeIf.onbranch:refs/heads/master.path.
But it would never do so even if the feature were implemented, since the
onbranch matching code uses the short refname "master".

The test still serves its purpose, since the bug fixed by 85fe0e800c is
actually that we hit a BUG() before even deciding whether to match the
ref. But let's use the correct name to avoid confusion (and which we'll
eventually want to trigger once we do the "real" fix described in that
commit).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t1309-early-config.sh
index 0c37e7180d1cde57d49c12deb28239c509d9207d..eeb60e41437ddeaa99b48d16f9bafced65f8b8b0 100755 (executable)
@@ -91,7 +91,7 @@ test_expect_failure 'ignore .git/ with invalid config' '
 
 test_expect_success 'early config and onbranch' '
        echo "[broken" >broken &&
-       test_with_config "[includeif \"onbranch:refs/heads/master\"]path=../broken"
+       test_with_config "[includeif \"onbranch:master\"]path=../broken"
 '
 
 test_done