lib-httpd/apache.conf: check version only after mod_version loads
authorJeff King <peff@peff.net>
Fri, 21 Jun 2013 18:12:51 +0000 (14:12 -0400)
committerJunio C Hamano <gitster@pobox.com>
Fri, 21 Jun 2013 20:58:06 +0000 (13:58 -0700)
Commit 0442743 introduced an <IfVersion> directive near the
top of the apache config file. However, at that point we
have not yet checked for and loaded the mod_version module.
This means that the directive will behave oddly if
mod_version is dynamically loaded, failing to match when it
should.

We can fix this by moving the whole block below the
LoadModule directive for mod_version.

Reported-by: Brian Gernhardt <brian@gernhardtsoftware.com>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/lib-httpd/apache.conf
index 67b6db136e3755bd4dbfffb7f28ff04f40eeb6f8..0f6f9abbb14dd97c152e694c166107d8c4d1ba3b 100644 (file)
@@ -1,7 +1,4 @@
 ServerName dummy
-<IfVersion < 2.4>
-LockFile accept.lock
-</IfVersion>
 PidFile httpd.pid
 DocumentRoot www
 LogFormat "%h %l %u %t \"%r\" %>s %b" common
@@ -26,6 +23,10 @@ ErrorLog error.log
        LoadModule version_module modules/mod_version.so
 </IfModule>
 
+<IfVersion < 2.4>
+LockFile accept.lock
+</IfVersion>
+
 <IfVersion < 2.1>
 <IfModule !mod_auth.c>
        LoadModule auth_module modules/mod_auth.so