send-email: send_message die on $!, not $?
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Thu, 30 Sep 2010 13:43:07 +0000 (13:43 +0000)
committerJunio C Hamano <gitster@pobox.com>
Thu, 30 Sep 2010 19:20:33 +0000 (12:20 -0700)
If close fails we want to emit errno, not the return code of whatever
happened to be the child process run.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.comReviewed-by: Avery Pennarun <apenwarr@gmail.com>
Reviewed-by: Jeff King <peff@peff.net>
>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
git-send-email.perl
index 5a0c4a8aefe8c1d5ea20ce783ff616c941535750..1e7adc20916e1674c4437d4d4297e89f2a4d2e87 100755 (executable)
@@ -1035,7 +1035,7 @@ sub send_message {
                        exec($smtp_server, @sendmail_parameters) or die $!;
                }
                print $sm "$header\n$message";
-               close $sm or die $?;
+               close $sm or die $!;
        } else {
 
                if (!defined $smtp_server) {