submodule: rename free_submodules_sha1s()
authorBrandon Williams <bmwill@google.com>
Fri, 28 Apr 2017 23:53:58 +0000 (16:53 -0700)
committerJunio C Hamano <gitster@pobox.com>
Mon, 1 May 2017 03:18:38 +0000 (12:18 +0900)
Rename 'free_submodules_sha1s()' to 'free_submodules_oids()' since the
function frees a 'struct string_list' which has a 'struct oid_array'
stored in the 'util' field.

Signed-off-by: Brandon Williams <bmwill@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
submodule.c
index be0f5d8478dbb9ee9977cc0cb6819a54e8a0b09f..46abd52b14db1d3dcdcf661eec70d5d494b7a6c1 100644 (file)
@@ -738,7 +738,7 @@ static void find_unpushed_submodule_commits(struct commit *commit,
        diff_tree_combined_merge(commit, 1, &rev);
 }
 
-static void free_submodules_sha1s(struct string_list *submodules)
+static void free_submodules_oids(struct string_list *submodules)
 {
        struct string_list_item *item;
        for_each_string_list_item(item, submodules)
@@ -779,7 +779,8 @@ int find_unpushed_submodules(struct oid_array *commits,
                if (submodule_needs_pushing(submodule->string, commits))
                        string_list_insert(needs_pushing, submodule->string);
        }
-       free_submodules_sha1s(&submodules);
+
+       free_submodules_oids(&submodules);
 
        return needs_pushing->nr;
 }