Andrew's git
/
gitweb.git
/ diff
summary
|
log
|
commit
| diff |
tree
commit
grep
author
committer
pickaxe
?
re
Merge branch 'tb/test-lint-echo-e'
author
Junio C Hamano
<gitster@pobox.com>
Mon, 25 Sep 2017 06:24:09 +0000
(15:24 +0900)
committer
Junio C Hamano
<gitster@pobox.com>
Mon, 25 Sep 2017 06:24:09 +0000
(15:24 +0900)
The test linter has been taught that we do not like "echo -e".
* tb/test-lint-echo-e:
test-lint: echo -e (or -E) is not portable
t/check-non-portable-shell.pl
patch
|
blob
|
history
raw
(from parent 1:
2bab096
)
diff --git
a/t/check-non-portable-shell.pl
b/t/check-non-portable-shell.pl
index b170cbc0452ca1b5a624f5cf330d420c397cb760..03dc9d28525730cdf57c74d13cab22da59dcdfbd 100755
(executable)
--- a/
t/check-non-portable-shell.pl
+++ b/
t/check-non-portable-shell.pl
@@
-17,7
+17,7
@@
sub err {
while (<>) {
chomp;
/\bsed\s+-i/ and err 'sed -i is not portable';
- /\becho\s+-
n/ and err 'echo -
n is not portable (please use printf)';
+ /\becho\s+-
[neE]/ and err 'echo with optio
n is not portable (please use printf)';
/^\s*declare\s+/ and err 'arrays/declare not portable';
/^\s*[^#]\s*which\s/ and err 'which is not portable (please use type)';
/\btest\s+[^=]*==/ and err '"test a == b" is not portable (please use =)';