match_push_refs(): nobody sets src->peer_ref anymore
authorJunio C Hamano <gitster@pobox.com>
Mon, 4 Mar 2013 22:36:33 +0000 (14:36 -0800)
committerJunio C Hamano <gitster@pobox.com>
Mon, 4 Mar 2013 23:01:11 +0000 (15:01 -0800)
In ancient times, we used to disallow the same source ref to be
pushed to more than one places, e.g. "git push there master:master
master:naster" was disallowed. We later lifted this restriction
with db27ee63929f (send-pack: allow the same source to be pushed
more than once., 2005-08-06) and there no longer is anybody that
sets peer_ref for the source side of the ref list in the push
codepath since then.

Remove one leftover no-op in a loop that iterates over the source
side of ref list (i.e. our local ref) to see if it can/should be
sent to a matching destination ref while skipping ones that is
marked with peer_ref (which will never exist, so we do not skip
anything).

Signed-off-by: Junio C Hamano <gitster@pobox.com>
remote.c
index ca1f8f2eafbef40046f2890501ad757bde9585f1..f065603c5db36318f33eaa3e244d0d6791db3d15 100644 (file)
--- a/remote.c
+++ b/remote.c
@@ -1227,9 +1227,6 @@ int match_push_refs(struct ref *src, struct ref **dst,
                const struct refspec *pat = NULL;
                char *dst_name;
 
-               if (ref->peer_ref)
-                       continue;
-
                dst_name = get_ref_match(rs, nr_refspec, ref, send_mirror, FROM_SRC, &pat);
                if (!dst_name)
                        continue;