Merge branch 'maint'
authorJunio C Hamano <gitster@pobox.com>
Thu, 13 Dec 2012 19:13:56 +0000 (11:13 -0800)
committerJunio C Hamano <gitster@pobox.com>
Thu, 13 Dec 2012 19:13:56 +0000 (11:13 -0800)
Documentation/git.txt
builtin/pack-redundant.c
index 25e2f3a60e6e608f866e8be8cce3e500f907c605..1d797f27ed7682cf7308949b99d4bc27f9767f1a 100644 (file)
@@ -650,6 +650,7 @@ git so take care if using Cogito etc.
        If the 'GIT_DIR' environment variable is set then it
        specifies a path to use instead of the default `.git`
        for the base of the repository.
+       The '--git-dir' command-line option also sets this value.
 
 'GIT_WORK_TREE'::
        Set the path to the working tree.  The value will not be
index f5c6afc5dd46c8f856d0f125287724bbfdc65db7..649c3aaa93ccdaae21b7884209bd4f28fb558f3e 100644 (file)
@@ -301,14 +301,14 @@ static void pll_free(struct pll *l)
  */
 static struct pll * get_permutations(struct pack_list *list, int n)
 {
-       struct pll *subset, *ret = NULL, *new_pll = NULL, *pll;
+       struct pll *subset, *ret = NULL, *new_pll = NULL;
 
        if (list == NULL || pack_list_size(list) < n || n == 0)
                return NULL;
 
        if (n == 1) {
                while (list) {
-                       new_pll = xmalloc(sizeof(pll));
+                       new_pll = xmalloc(sizeof(*new_pll));
                        new_pll->pl = NULL;
                        pack_list_insert(&new_pll->pl, list);
                        new_pll->next = ret;
@@ -321,7 +321,7 @@ static struct pll * get_permutations(struct pack_list *list, int n)
        while (list->next) {
                subset = get_permutations(list->next, n - 1);
                while (subset) {
-                       new_pll = xmalloc(sizeof(pll));
+                       new_pll = xmalloc(sizeof(*new_pll));
                        new_pll->pl = subset->pl;
                        pack_list_insert(&new_pll->pl, list);
                        new_pll->next = ret;