gitweb: bugfix: a.list formatting regression

Fix regression introduced by
commit 17d07443188909ef5f8b8c24043cb6d9fef51bca.

"a.list" being "bold", makes a myriad of things shown by
gitweb in bold font-weight, which is a regression from
pre-17d07443188909ef5f8b8c24043cb6d9fef51bca behavior.

The fix is to add "subject" class and use this class
to replace pre-format_subject_html formatting of subject
(comment) via using (or not) <b>...</b> element. This
should go back to the pre-17d0744318... style.

Regression noticed by Luben Tuikov.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>

diff --git a/gitweb/gitweb.css b/gitweb/gitweb.css
index 9013895857b76ea879e58ea90f2885d6744d1127..6c13d9ed10d1f3435887890a77b2c786b1a571a6 100644 (file)
--- a/gitweb/gitweb.css
+++ b/gitweb/gitweb.css
@@ -117,11 +117,14 @@ div.list_head {
 
 a.list {
        text-decoration: none;
 
 a.list {
        text-decoration: none;

-       font-weight: bold;

        color: #000000;
 }
 
        color: #000000;
 }
 

-table.tags a.list {
+a.subject {
+       font-weight: bold;
+}
+
+table.tags a.subject {

        font-weight: normal;
 }
 
        font-weight: normal;
 }
 

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 31a1824d7a5d04b2cf7fc4d0b99a4dc98a73dc65..0e4697731d1b26b516c09401610701e46aea2b92 100755 (executable)
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -504,11 +504,11 @@ sub format_subject_html {
        $extra = '' unless defined($extra);
 
        if (length($short) < length($long)) {
        $extra = '' unless defined($extra);
 
        if (length($short) < length($long)) {

-               return $cgi->a({-href => $href, -class => "list",
+               return $cgi->a({-href => $href, -class => "list subject",

                                -title => $long},
                       esc_html($short) . $extra);
        } else {
                                -title => $long},
                       esc_html($short) . $extra);
        } else {

-               return $cgi->a({-href => $href, -class => "list"},
+               return $cgi->a({-href => $href, -class => "list subject"},

                       esc_html($long)  . $extra);
        }
 }
                       esc_html($long)  . $extra);
        }
 }