push: change needlessly ambiguous example in error
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Tue, 13 Nov 2018 20:39:09 +0000 (20:39 +0000)
committerJunio C Hamano <gitster@pobox.com>
Wed, 14 Nov 2018 08:17:09 +0000 (17:17 +0900)
Change an example push added in b55e677522 ("push: introduce new
push.default mode "simple"", 2012-04-24) to always mean the same thing
whether the current setting happens to be "simple" or not.

This error is only emitted under "simple", but message is explaining
to the user that they can get two sorts of different behaviors by
these two invocations.

Let's use "git push <remote> HEAD" which always means push the current
branch name to that remote, instead of "git push <remote>
<current-branch-name>" which will do that under "simple", but is not
guaranteed to do under "upstream".

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/push.c
index d09a42062c36d930b8147d6b0a4bcfedf34a2321..8bb8a0849ba90aff5d295acc3894b2034cbbdef2 100644 (file)
@@ -173,10 +173,10 @@ static NORETURN int die_push_simple(struct branch *branch, struct remote *remote
              "\n"
              "To push to the branch of the same name on the remote, use\n"
              "\n"
-             "    git push %s %s\n"
+             "    git push %s HEAD\n"
              "%s"),
            remote->name, short_upstream,
-           remote->name, branch->name, advice_maybe);
+           remote->name, advice_maybe);
 }
 
 static const char message_detached_head_die[] =