gitweb: Clean up code in git_search_* subroutines

Replace sequence of

$foo .= "bar";
$foo .= "baz";

with

$foo .= "bar" .
"baz";

Use href(-replay=>1, -page=>undef) for first page of a multipl-page view.

Wrap some lines to reduce their length. Some lines still have more than 80
characters, but lines are shorter now.

No functional changes intended.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 9d9dc0149cea0ba4c99ef7a4d90c46be34427d84..80cbe66eab5d1c680a1f39c1608a34522730d609 100755 (executable)
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -5273,16 +5273,13 @@ sub git_search_message {
        my $paging_nav = '';
        if ($page > 0) {
                $paging_nav .=
        my $paging_nav = '';
        if ($page > 0) {
                $paging_nav .=

-                       $cgi->a({-href => href(action=>"search", hash=>$hash,
-                                              searchtext=>$searchtext,
-                                              searchtype=>$searchtype)},
-                               "first");
-               $paging_nav .= " ⋅ " .
+                       $cgi->a({-href => href(-replay=>1, page=>undef)},
+                               "first") .
+                       " ⋅ " .

                        $cgi->a({-href => href(-replay=>1, page=>$page-1),
                                 -accesskey => "p", -title => "Alt-p"}, "prev");
        } else {
                        $cgi->a({-href => href(-replay=>1, page=>$page-1),
                                 -accesskey => "p", -title => "Alt-p"}, "prev");
        } else {

-               $paging_nav .= "first";
-               $paging_nav .= " ⋅ prev";
+               $paging_nav .= "first ⋅ prev";

        }
        my $next_link = '';
        if ($#commitlist >= 100) {
        }
        my $next_link = '';
        if ($#commitlist >= 100) {


@@ -5327,10 +5324,13 @@ sub git_search_changes {
                        if (%co) {
                                print "</td>\n" .
                                      "<td class=\"link\">" .
                        if (%co) {
                                print "</td>\n" .
                                      "<td class=\"link\">" .

-                                     $cgi->a({-href => href(action=>"commit", hash=>$co{'id'})}, "commit") .
+                                     $cgi->a({-href => href(action=>"commit", hash=>$co{'id'})},
+                                             "commit") .

                                      " | " .
                                      " | " .

-                                     $cgi->a({-href => href(action=>"tree", hash=>$co{'tree'}, hash_base=>$co{'id'})}, "tree");
-                               print "</td>\n" .
+                                     $cgi->a({-href => href(action=>"tree", hash=>$co{'tree'},
+                                                            hash_base=>$co{'id'})},
+                                             "tree") .
+                                     "</td>\n" .

                                      "</tr>\n";
                        }
 
                                      "</tr>\n";
                        }
 


@@ -5364,10 +5364,13 @@ sub git_search_changes {
        if (%co) {
                print "</td>\n" .
                      "<td class=\"link\">" .
        if (%co) {
                print "</td>\n" .
                      "<td class=\"link\">" .

-                     $cgi->a({-href => href(action=>"commit", hash=>$co{'id'})}, "commit") .
+                     $cgi->a({-href => href(action=>"commit", hash=>$co{'id'})},
+                             "commit") .

                      " | " .
                      " | " .

-                     $cgi->a({-href => href(action=>"tree", hash=>$co{'tree'}, hash_base=>$co{'id'})}, "tree");
-               print "</td>\n" .
+                     $cgi->a({-href => href(action=>"tree", hash=>$co{'tree'},
+                                            hash_base=>$co{'id'})},
+                             "tree") .
+                     "</td>\n" .

                      "</tr>\n";
        }
 
                      "</tr>\n";
        }