http: style fixes for curl_multi_init error check
authorJeff King <peff@peff.net>
Sun, 17 Aug 2014 07:35:53 +0000 (03:35 -0400)
committerJunio C Hamano <gitster@pobox.com>
Thu, 21 Aug 2014 17:53:55 +0000 (10:53 -0700)
Unless there is a good reason, we should use die() rather than
fprintf/exit. We can also shorten the message to match other curl init
failures (and match our usual lowercase no-full-stop style).

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
http.c
diff --git a/http.c b/http.c
index 0276aa94261c82fc4bcec2ae731e6566a39be0a3..d33b122cd15f9d1b712c837c35a3c918f3e3f3ad 100644 (file)
--- a/http.c
+++ b/http.c
@@ -421,10 +421,8 @@ void http_init(struct remote *remote, const char *url, int proactive_auth)
        }
 
        curlm = curl_multi_init();
-       if (curlm == NULL) {
-               fprintf(stderr, "Error creating curl multi handle.\n");
-               exit(1);
-       }
+       if (!curlm)
+               die("curl_multi_init failed");
 #endif
 
        if (getenv("GIT_SSL_NO_VERIFY"))