Merge branch 'nd/transport-positive-depth-only'

"git fetch --depth=0" was a no-op, and was silently
ignored. Diagnose it as an error.

* nd/transport-positive-depth-only:
clone,fetch: catch non positive --depth option value

diff --git a/builtin/clone.c b/builtin/clone.c
index ec4d1cd2bb5c4bb2c8c669924570f3492e018087..f98f52980d3b8f7a4700d37c486c4379a4dd15ed 100644 (file)
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -796,6 +796,10 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
        if (option_local > 0 && !is_local)
                warning(_("--local is ignored"));
 
+       /* no need to be strict, transport_set_option() will validate it again */
+       if (option_depth && atoi(option_depth) < 1)
+               die(_("depth %s is not a positive number"), option_depth);
+
        if (argc == 2)
                dir = xstrdup(argv[1]);
        else

diff --git a/builtin/fetch.c b/builtin/fetch.c
index e3ac84a0dd14612afdb1eca9f265767a701bc810..1e7d617f4671c43f704afe912edac5f5dc6dc316 100644 (file)
--- a/builtin/fetch.c
+++ b/builtin/fetch.c
@@ -1079,6 +1079,10 @@ int cmd_fetch(int argc, const char **argv, const char *prefix)
                }
        }
 
+       /* no need to be strict, transport_set_option() will validate it again */
+       if (depth && atoi(depth) < 1)
+               die(_("depth %s is not a positive number"), depth);
+
        if (recurse_submodules != RECURSE_SUBMODULES_OFF) {
                if (recurse_submodules_default) {
                        int arg = parse_fetch_recurse_submodules_arg("--recurse-submodules-default", recurse_submodules_default);