Andrew's git
/
gitweb.git
/ diff
summary
|
log
|
commit
| diff |
tree
commit
grep
author
committer
pickaxe
?
re
Don't rely on unspecified behavior
author
Thomas Schwinge
<tschwinge@gnu.org>
Sat, 28 Jul 2007 18:26:35 +0000
(20:26 +0200)
committer
Junio C Hamano
<gitster@pobox.com>
Sun, 29 Jul 2007 01:50:36 +0000
(18:50 -0700)
Calling access(p, m) with p == NULL is not specified, so don't do that. On
GNU/Hurd systems doing so will result in a SIGSEGV.
Signed-off-by: Thomas Schwinge <tschwinge@gnu.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin-add.c
patch
|
blob
|
history
raw
|
patch
| inline |
side by side
(parent:
1207510
)
diff --git
a/builtin-add.c
b/builtin-add.c
index 734547994f3a35e04fc7fdea10396c0c87bc6f0d..de5c108f8f5765e78c8ca15dcad58f3796015acc 100644
(file)
--- a/
builtin-add.c
+++ b/
builtin-add.c
@@
-60,7
+60,7
@@
static void fill_directory(struct dir_struct *dir, const char **pathspec,
path = git_path("info/exclude");
if (!access(path, R_OK))
add_excludes_from_file(dir, path);
- if (!access(excludes_file, R_OK))
+ if (
excludes_file != NULL &&
!access(excludes_file, R_OK))
add_excludes_from_file(dir, excludes_file);
}