Merge branch 'tr/copy-revisions-from-stdin'
authorJunio C Hamano <gitster@pobox.com>
Fri, 19 Apr 2013 20:40:13 +0000 (13:40 -0700)
committerJunio C Hamano <gitster@pobox.com>
Fri, 19 Apr 2013 20:40:13 +0000 (13:40 -0700)
A fix to a long-standing issue in the command line parser for
revisions, which was triggered by mv/sequence-pick-error-diag topic.

* tr/copy-revisions-from-stdin:
read_revisions_from_stdin: make copies for handle_revision_arg

revision.c
index eb981288686a2c7cd8c854e3f414b606ed4f8c69..56d666d69a8a961d33651c0658f7009967e0b7ab 100644 (file)
@@ -1276,7 +1276,8 @@ static void read_revisions_from_stdin(struct rev_info *revs,
                        }
                        die("options not supported in --stdin mode");
                }
-               if (handle_revision_arg(sb.buf, revs, 0, REVARG_CANNOT_BE_FILENAME))
+               if (handle_revision_arg(xstrdup(sb.buf), revs, 0,
+                                       REVARG_CANNOT_BE_FILENAME))
                        die("bad revision '%s'", sb.buf);
        }
        if (seen_dashdash)