Merge branch 'rs/help-unknown-ref-does-not-return'
authorJunio C Hamano <gitster@pobox.com>
Mon, 30 Sep 2019 04:19:27 +0000 (13:19 +0900)
committerJunio C Hamano <gitster@pobox.com>
Mon, 30 Sep 2019 04:19:27 +0000 (13:19 +0900)
Code cleanup.

* rs/help-unknown-ref-does-not-return:
help: make help_unknown_ref() NORETURN

help.c
help.h
diff --git a/help.c b/help.c
index 5261d83ecf15042d8babccf9779f0b96fac94e92..9ff2be6b188fe890e0a9ba28b63effbdf99036ef 100644 (file)
--- a/help.c
+++ b/help.c
@@ -774,7 +774,8 @@ static struct string_list guess_refs(const char *ref)
        return similar_refs;
 }
 
-void help_unknown_ref(const char *ref, const char *cmd, const char *error)
+NORETURN void help_unknown_ref(const char *ref, const char *cmd,
+                              const char *error)
 {
        int i;
        struct string_list suggested_refs = guess_refs(ref);
diff --git a/help.h b/help.h
index b8780fbd0fc3d0daacf029b3c3fcdd9a41bc733e..7a455beeb725e267946b1ac2c4d91ba9fee2a8c1 100644 (file)
--- a/help.h
+++ b/help.h
@@ -43,7 +43,7 @@ void list_commands(unsigned int colopts, struct cmdnames *main_cmds, struct cmdn
  * call this to die(), when it is suspected that the user mistyped a
  * ref to the command, to give suggested "correct" refs.
  */
-void help_unknown_ref(const char *ref, const char *cmd, const char *error);
+NORETURN void help_unknown_ref(const char *ref, const char *cmd, const char *error);
 
 static inline void list_config_item(struct string_list *list,
                                    const char *prefix,