tests: introduce test_must_fail
authorJunio C Hamano <gitster@pobox.com>
Thu, 28 Feb 2008 21:09:30 +0000 (13:09 -0800)
committerJunio C Hamano <gitster@pobox.com>
Mon, 3 Mar 2008 07:15:06 +0000 (23:15 -0800)
When we expect a git command to notice and signal errors, we
carelessly wrote in our tests:

test_expect_success 'reject bogus request' '
do something &&
do something else &&
! git command
'

but a non-zero exit could come from the "git command" segfaulting.

A new helper function "tset_must_fail" is introduced and it is
meant to be used to make sure the command gracefully fails (iow,
dying and exiting with non zero status is counted as a failure
to "gracefully fail"). The above example should be written as:

test_expect_success 'reject bogus request' '
do something &&
do something else &&
test_must_fail git command
'

Signed-off-by: Junio C Hamano <gitster@pobox.com>
No differences found