remote.c: turn some error() or die() to BUG()

The first error, "internal error", is clearly a BUG(). The second two
are meant to catch calls with invalid parameters and should never
happen outside the test suite.

Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/remote.c b/remote.c
index 81f4f01b00715b38f0d10fc03fad75f17aa1cf47..257630ff21e1567c5613a0629d57b0b868ab794b 100644 (file)
--- a/remote.c
+++ b/remote.c
@@ -620,7 +620,7 @@ static void handle_duplicate(struct ref *ref1, struct ref *ref2)
                         * FETCH_HEAD_IGNORE entries always appear at
                         * the end of the list.
                         */
                         * FETCH_HEAD_IGNORE entries always appear at
                         * the end of the list.
                         */

-                       die(_("Internal error"));
+                       BUG("Internal error");

                }
        }
        free(ref2->peer_ref);
                }
        }
        free(ref2->peer_ref);


@@ -707,7 +707,7 @@ static void query_refspecs_multiple(struct refspec *rs,
        int find_src = !query->src;
 
        if (find_src && !query->dst)
        int find_src = !query->src;
 
        if (find_src && !query->dst)

-               error("query_refspecs_multiple: need either src or dst");
+               BUG("query_refspecs_multiple: need either src or dst");

 
        for (i = 0; i < rs->nr; i++) {
                struct refspec_item *refspec = &rs->items[i];
 
        for (i = 0; i < rs->nr; i++) {
                struct refspec_item *refspec = &rs->items[i];


@@ -735,7 +735,7 @@ int query_refspecs(struct refspec *rs, struct refspec_item *query)
        char **result = find_src ? &query->src : &query->dst;
 
        if (find_src && !query->dst)
        char **result = find_src ? &query->src : &query->dst;
 
        if (find_src && !query->dst)

-               return error("query_refspecs: need either src or dst");
+               BUG("query_refspecs: need either src or dst");

 
        for (i = 0; i < rs->nr; i++) {
                struct refspec_item *refspec = &rs->items[i];
 
        for (i = 0; i < rs->nr; i++) {
                struct refspec_item *refspec = &rs->items[i];