git-rev-list: remove the DUPCHECK logic, use SEEN instead

That's what we should have done in the first place, since it not only
avoids another unnecessary flag, it also protects the commits from
showing up as duplicates later when they show up as parents of another
commit (in the pop_most_recent_commit() path).

This will hopefully also fix --topo-sort.

diff --git a/rev-list.c b/rev-list.c
index fb3372476ca51d0569e831bd6e4ad7efa068c898..0dd45129e6678415f6578b4fc4a1234c6035fc77 100644 (file)
--- a/rev-list.c
+++ b/rev-list.c
@@ -9,7 +9,6 @@
 #define INTERESTING    (1u << 1)
 #define COUNTED                (1u << 2)
 #define SHOWN          (1u << 3)
-#define DUPCHECK       (1u << 4)
 
 static const char rev_list_usage[] =
        "usage: git-rev-list [OPTION] commit-id <commit-id>\n"
@@ -488,9 +487,9 @@ int main(int argc, char **argv)
                commit = get_commit_reference(arg, flags);
                if (!commit)
                        continue;
-               if (commit->object.flags & DUPCHECK)
+               if (commit->object.flags & SEEN)
                        continue;
-               commit->object.flags |= DUPCHECK;
+               commit->object.flags |= SEEN;
                insert(commit, &list);
        }