Make sure the empty tree exists when needed in merge-recursive.
authorShawn O. Pearce <spearce@spearce.org>
Thu, 7 Dec 2006 10:17:07 +0000 (05:17 -0500)
committerJunio C Hamano <junkio@cox.net>
Mon, 11 Dec 2006 22:11:40 +0000 (14:11 -0800)
There are some baseless merge cases where git-merge-recursive will
try to compare one of the branches against the empty tree. However
most projects won't have the empty tree object in their object database
as Git does not normally create empty tree objects. If the empty tree
object is missing then the merge process will die, as it cannot load the
object from the database. The error message may make the user think that
their database is corrupt when its actually not.

So instead we should just create the empty tree object whenever it is
needed. If the object already exists as a loose object then no harm
done. Otherwise that loose object will be pruned away later by either
git-prune or git-prune-packed.

Thanks goes to Junio for suggesting this fix.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
merge-recursive.c
index cd2cc77bf47025a9dfc88f594961521c3ec8f22c..32e186c15e7dcdaff99f09a7edcf50a691c7ee74 100644 (file)
@@ -1238,7 +1238,7 @@ static int merge(struct commit *h1,
 
                tree->object.parsed = 1;
                tree->object.type = OBJ_TREE;
-               hash_sha1_file(NULL, 0, tree_type, tree->object.sha1);
+               write_sha1_file(NULL, 0, tree_type, tree->object.sha1);
                merged_common_ancestors = make_virtual_commit(tree, "ancestor");
        }