Merge branch 'cw/no-detaching-an-unborn' into maint
authorJunio C Hamano <gitster@pobox.com>
Sun, 22 Jul 2012 20:00:31 +0000 (13:00 -0700)
committerJunio C Hamano <gitster@pobox.com>
Sun, 22 Jul 2012 20:00:32 +0000 (13:00 -0700)
"git checkout --detach", when you are still on an unborn branch,
should be forbidden, but it wasn't.

* cw/no-detaching-an-unborn:
git-checkout: disallow --detach on unborn branch

1  2 
builtin/checkout.c
diff --combined builtin/checkout.c
index e8c1b1f189f077529ef2a79accb46ef21a9b8fe7,a94b553d054b28eee83ce6b9bd54be4659279239..3980d5d06ea5aba4f4d6d30089307fe76c8adff9
@@@ -19,7 -19,6 +19,7 @@@
  #include "ll-merge.h"
  #include "resolve-undo.h"
  #include "submodule.h"
 +#include "argv-array.h"
  
  static const char * const checkout_usage[] = {
        "git checkout [options] <branch>",
@@@ -34,7 -33,6 +34,7 @@@ struct checkout_opts 
        int force_detach;
        int writeout_stage;
        int writeout_error;
 +      int overwrite_ignore;
  
        /* not set by parse_options */
        int branch_exists;
@@@ -73,7 -71,7 +73,7 @@@ static int update_some(const unsigned c
        hashcpy(ce->sha1, sha1);
        memcpy(ce->name, base, baselen);
        memcpy(ce->name + baselen, pathname, len - baselen);
 -      ce->ce_flags = create_ce_flags(len, 0);
 +      ce->ce_flags = create_ce_flags(len, 0) | CE_UPDATE;
        ce->ce_mode = create_ce_mode(mode);
        add_cache_entry(ce, ADD_CACHE_OK_TO_ADD | ADD_CACHE_OK_TO_REPLACE);
        return 0;
@@@ -115,21 -113,16 +115,21 @@@ static int check_stage(int stage, struc
                return error(_("path '%s' does not have their version"), ce->name);
  }
  
 -static int check_all_stages(struct cache_entry *ce, int pos)
 +static int check_stages(unsigned stages, struct cache_entry *ce, int pos)
  {
 -      if (ce_stage(ce) != 1 ||
 -          active_nr <= pos + 2 ||
 -          strcmp(active_cache[pos+1]->name, ce->name) ||
 -          ce_stage(active_cache[pos+1]) != 2 ||
 -          strcmp(active_cache[pos+2]->name, ce->name) ||
 -          ce_stage(active_cache[pos+2]) != 3)
 -              return error(_("path '%s' does not have all three versions"),
 -                           ce->name);
 +      unsigned seen = 0;
 +      const char *name = ce->name;
 +
 +      while (pos < active_nr) {
 +              ce = active_cache[pos];
 +              if (strcmp(name, ce->name))
 +                      break;
 +              seen |= (1 << ce_stage(ce));
 +              pos++;
 +      }
 +      if ((stages & seen) != stages)
 +              return error(_("path '%s' does not have all necessary versions"),
 +                           name);
        return 0;
  }
  
@@@ -156,27 -149,18 +156,27 @@@ static int checkout_merged(int pos, str
        int status;
        unsigned char sha1[20];
        mmbuffer_t result_buf;
 +      unsigned char threeway[3][20];
 +      unsigned mode = 0;
 +
 +      memset(threeway, 0, sizeof(threeway));
 +      while (pos < active_nr) {
 +              int stage;
 +              stage = ce_stage(ce);
 +              if (!stage || strcmp(path, ce->name))
 +                      break;
 +              hashcpy(threeway[stage - 1], ce->sha1);
 +              if (stage == 2)
 +                      mode = create_ce_mode(ce->ce_mode);
 +              pos++;
 +              ce = active_cache[pos];
 +      }
 +      if (is_null_sha1(threeway[1]) || is_null_sha1(threeway[2]))
 +              return error(_("path '%s' does not have necessary versions"), path);
  
 -      if (ce_stage(ce) != 1 ||
 -          active_nr <= pos + 2 ||
 -          strcmp(active_cache[pos+1]->name, path) ||
 -          ce_stage(active_cache[pos+1]) != 2 ||
 -          strcmp(active_cache[pos+2]->name, path) ||
 -          ce_stage(active_cache[pos+2]) != 3)
 -              return error(_("path '%s' does not have all 3 versions"), path);
 -
 -      read_mmblob(&ancestor, active_cache[pos]->sha1);
 -      read_mmblob(&ours, active_cache[pos+1]->sha1);
 -      read_mmblob(&theirs, active_cache[pos+2]->sha1);
 +      read_mmblob(&ancestor, threeway[0]);
 +      read_mmblob(&ours, threeway[1]);
 +      read_mmblob(&theirs, threeway[2]);
  
        /*
         * NEEDSWORK: re-create conflicts from merges with
        if (write_sha1_file(result_buf.ptr, result_buf.size,
                            blob_type, sha1))
                die(_("Unable to add merge result for '%s'"), path);
 -      ce = make_cache_entry(create_ce_mode(active_cache[pos+1]->ce_mode),
 -                            sha1,
 -                            path, 2, 0);
 +      ce = make_cache_entry(mode, sha1, path, 2, 0);
        if (!ce)
                die(_("make_cache_entry failed for path '%s'"), path);
        status = checkout_entry(ce, state, NULL);
@@@ -242,8 -228,6 +242,8 @@@ static int checkout_paths(struct tree *
  
        for (pos = 0; pos < active_nr; pos++) {
                struct cache_entry *ce = active_cache[pos];
 +              if (source_tree && !(ce->ce_flags & CE_UPDATE))
 +                      continue;
                match_pathspec(pathspec, ce->name, ce_namelen(ce), 0, ps_matched);
        }
  
                        } else if (stage) {
                                errs |= check_stage(stage, ce, pos);
                        } else if (opts->merge) {
 -                              errs |= check_all_stages(ce, pos);
 +                              errs |= check_stages((1<<2) | (1<<3), ce, pos);
                        } else {
                                errs = 1;
                                error(_("path '%s' is unmerged"), ce->name);
        state.refresh_cache = 1;
        for (pos = 0; pos < active_nr; pos++) {
                struct cache_entry *ce = active_cache[pos];
 +              if (source_tree && !(ce->ce_flags & CE_UPDATE))
 +                      continue;
                if (match_pathspec(pathspec, ce->name, ce_namelen(ce), 0, NULL)) {
                        if (!ce_stage(ce)) {
                                errs |= checkout_entry(ce, &state, NULL);
            commit_locked_index(lock_file))
                die(_("unable to write new index file"));
  
 -      resolve_ref("HEAD", rev, 0, &flag);
 +      read_ref_full("HEAD", rev, 0, &flag);
        head = lookup_commit_reference_gently(rev, 1);
  
        errs |= post_checkout_hook(head, head, 0);
@@@ -343,7 -325,7 +343,7 @@@ static int reset_tree(struct tree *tree
        opts.reset = 1;
        opts.merge = 1;
        opts.fn = oneway_merge;
 -      opts.verbose_update = !o->quiet;
 +      opts.verbose_update = !o->quiet && isatty(2);
        opts.src_index = &the_index;
        opts.dst_index = &the_index;
        parse_tree(tree);
@@@ -420,13 -402,11 +420,13 @@@ static int merge_working_tree(struct ch
                topts.update = 1;
                topts.merge = 1;
                topts.gently = opts->merge && old->commit;
 -              topts.verbose_update = !opts->quiet;
 +              topts.verbose_update = !opts->quiet && isatty(2);
                topts.fn = twoway_merge;
 -              topts.dir = xcalloc(1, sizeof(*topts.dir));
 -              topts.dir->flags |= DIR_SHOW_IGNORED;
 -              topts.dir->exclude_per_dir = ".gitignore";
 +              if (opts->overwrite_ignore) {
 +                      topts.dir = xcalloc(1, sizeof(*topts.dir));
 +                      topts.dir->flags |= DIR_SHOW_IGNORED;
 +                      setup_standard_excludes(topts.dir);
 +              }
                tree = parse_tree_indirect(old->commit ?
                                           old->commit->object.sha1 :
                                           EMPTY_TREE_SHA1_BIN);
@@@ -514,6 -494,20 +514,6 @@@ static void report_tracking(struct bran
        strbuf_release(&sb);
  }
  
 -static void detach_advice(const char *old_path, const char *new_name)
 -{
 -      const char fmt[] =
 -      "Note: checking out '%s'.\n\n"
 -      "You are in 'detached HEAD' state. You can look around, make experimental\n"
 -      "changes and commit them, and you can discard any commits you make in this\n"
 -      "state without impacting any branches by performing another checkout.\n\n"
 -      "If you want to create a new branch to retain commits you create, you may\n"
 -      "do so (now or later) by using -b with the checkout command again. Example:\n\n"
 -      "  git checkout -b new_branch_name\n\n";
 -
 -      fprintf(stderr, fmt, new_name);
 -}
 -
  static void update_refs_for_switch(struct checkout_opts *opts,
                                   struct branch_info *old,
                                   struct branch_info *new)
                else
                        create_branch(old->name, opts->new_branch, new->name,
                                      opts->new_branch_force ? 1 : 0,
 -                                    opts->new_branch_log, opts->track);
 +                                    opts->new_branch_log,
 +                                    opts->new_branch_force ? 1 : 0,
 +                                    opts->quiet,
 +                                    opts->track);
                new->name = opts->new_branch;
                setup_branch_path(new);
        }
                           REF_NODEREF, DIE_ON_ERR);
                if (!opts->quiet) {
                        if (old->path && advice_detached_head)
 -                              detach_advice(old->path, new->name);
 +                              detach_advice(new->name);
                        describe_detached_head(_("HEAD is now at"), new->commit);
                }
        } else if (new->path) { /* Switch branches. */
                create_symref("HEAD", new->path, msg.buf);
                if (!opts->quiet) {
                        if (old->path && !strcmp(new->path, old->path)) {
 -                              fprintf(stderr, _("Already on '%s'\n"),
 -                                      new->name);
 +                              if (opts->new_branch_force)
 +                                      fprintf(stderr, _("Reset branch '%s'\n"),
 +                                              new->name);
 +                              else
 +                                      fprintf(stderr, _("Already on '%s'\n"),
 +                                              new->name);
                        } else if (opts->new_branch) {
                                if (opts->branch_exists)
                                        fprintf(stderr, _("Switched to and reset branch '%s'\n"), new->name);
                report_tracking(new);
  }
  
 -struct rev_list_args {
 -      int argc;
 -      int alloc;
 -      const char **argv;
 -};
 -
 -static void add_one_rev_list_arg(struct rev_list_args *args, const char *s)
 -{
 -      ALLOC_GROW(args->argv, args->argc + 1, args->alloc);
 -      args->argv[args->argc++] = s;
 -}
 -
 -static int add_one_ref_to_rev_list_arg(const char *refname,
 -                                     const unsigned char *sha1,
 -                                     int flags,
 -                                     void *cb_data)
 -{
 -      add_one_rev_list_arg(cb_data, refname);
 -      return 0;
 -}
 -
 -static int clear_commit_marks_from_one_ref(const char *refname,
 -                                    const unsigned char *sha1,
 -                                    int flags,
 -                                    void *cb_data)
 +static int add_pending_uninteresting_ref(const char *refname,
 +                                       const unsigned char *sha1,
 +                                       int flags, void *cb_data)
  {
 -      struct commit *commit = lookup_commit_reference_gently(sha1, 1);
 -      if (commit)
 -              clear_commit_marks(commit, -1);
 +      add_pending_sha1(cb_data, refname, sha1, flags | UNINTERESTING);
        return 0;
  }
  
@@@ -646,25 -657,24 +646,25 @@@ static void suggest_reattach(struct com
                "Warning: you are leaving %d commit behind, "
                "not connected to\n"
                "any of your branches:\n\n"
 -              "%s\n"
 -              "If you want to keep it by creating a new branch, "
 -              "this may be a good time\nto do so with:\n\n"
 -              " git branch new_branch_name %s\n\n",
 +              "%s\n",
                /* The plural version */
                "Warning: you are leaving %d commits behind, "
                "not connected to\n"
                "any of your branches:\n\n"
 -              "%s\n"
 -              "If you want to keep them by creating a new branch, "
 -              "this may be a good time\nto do so with:\n\n"
 -              " git branch new_branch_name %s\n\n",
 +              "%s\n",
                /* Give ngettext() the count */
                lost),
                lost,
 -              sb.buf,
 -              sha1_to_hex(commit->object.sha1));
 +              sb.buf);
        strbuf_release(&sb);
 +
 +      if (advice_detached_head)
 +              fprintf(stderr,
 +                      _(
 +                      "If you want to keep them by creating a new branch, "
 +                      "this may be a good time\nto do so with:\n\n"
 +                      " git branch new_branch_name %s\n\n"),
 +                      sha1_to_hex(commit->object.sha1));
  }
  
  /*
   * HEAD.  If it is not reachable from any ref, this is the last chance
   * for the user to do so without resorting to reflog.
   */
 -static void orphaned_commit_warning(struct commit *commit)
 +static void orphaned_commit_warning(struct commit *old, struct commit *new)
  {
 -      struct rev_list_args args = { 0, 0, NULL };
        struct rev_info revs;
 -
 -      add_one_rev_list_arg(&args, "(internal)");
 -      add_one_rev_list_arg(&args, sha1_to_hex(commit->object.sha1));
 -      add_one_rev_list_arg(&args, "--not");
 -      for_each_ref(add_one_ref_to_rev_list_arg, &args);
 -      add_one_rev_list_arg(&args, "--");
 -      add_one_rev_list_arg(&args, NULL);
 +      struct object *object = &old->object;
 +      struct object_array refs;
  
        init_revisions(&revs, NULL);
 -      if (setup_revisions(args.argc - 1, args.argv, &revs, NULL) != 1)
 -              die(_("internal error: only -- alone should have been left"));
 +      setup_revisions(0, NULL, &revs, NULL);
 +
 +      object->flags &= ~UNINTERESTING;
 +      add_pending_object(&revs, object, sha1_to_hex(object->sha1));
 +
 +      for_each_ref(add_pending_uninteresting_ref, &revs);
 +      add_pending_sha1(&revs, "HEAD", new->object.sha1, UNINTERESTING);
 +
 +      refs = revs.pending;
 +      revs.leak_pending = 1;
 +
        if (prepare_revision_walk(&revs))
                die(_("internal error in revision walk"));
 -      if (!(commit->object.flags & UNINTERESTING))
 -              suggest_reattach(commit, &revs);
 +      if (!(old->object.flags & UNINTERESTING))
 +              suggest_reattach(old, &revs);
        else
 -              describe_detached_head(_("Previous HEAD position was"), commit);
 +              describe_detached_head(_("Previous HEAD position was"), old);
  
 -      clear_commit_marks(commit, -1);
 -      for_each_ref(clear_commit_marks_from_one_ref, NULL);
 +      clear_commit_marks_for_object_array(&refs, ALL_REV_FLAGS);
 +      free(refs.objects);
  }
  
  static int switch_branches(struct checkout_opts *opts, struct branch_info *new)
  {
        int ret = 0;
        struct branch_info old;
 +      void *path_to_free;
        unsigned char rev[20];
        int flag;
        memset(&old, 0, sizeof(old));
 -      old.path = xstrdup(resolve_ref("HEAD", rev, 0, &flag));
 +      old.path = path_to_free = resolve_refdup("HEAD", rev, 0, &flag);
        old.commit = lookup_commit_reference_gently(rev, 1);
 -      if (!(flag & REF_ISSYMREF)) {
 -              free((char *)old.path);
 +      if (!(flag & REF_ISSYMREF))
                old.path = NULL;
 -      }
  
        if (old.path && !prefixcmp(old.path, "refs/heads/"))
                old.name = old.path + strlen("refs/heads/");
        }
  
        ret = merge_working_tree(opts, &old, new);
 -      if (ret)
 +      if (ret) {
 +              free(path_to_free);
                return ret;
 +      }
  
        if (!opts->quiet && !old.path && old.commit && new->commit != old.commit)
 -              orphaned_commit_warning(old.commit);
 +              orphaned_commit_warning(old.commit, new->commit);
  
        update_refs_for_switch(opts, &old, new);
  
        ret = post_checkout_hook(old.commit, new->commit, 1);
 -      free((char *)old.path);
 +      free(path_to_free);
        return ret || opts->writeout_error;
  }
  
@@@ -875,8 -881,8 +875,8 @@@ static int parse_branchname_arg(int arg
        new->name = arg;
        setup_branch_path(new);
  
 -      if (check_ref_format(new->path) == CHECK_REF_FORMAT_OK &&
 -          resolve_ref(new->path, branch_rev, 1, NULL))
 +      if (!check_refname_format(new->path, 0) &&
 +          !read_ref(new->path, branch_rev))
                hashcpy(rev, branch_rev);
        else
                new->path = NULL; /* not an existing branch */
@@@ -915,6 -921,8 +915,8 @@@ static int switch_unborn_to_new_branch(
        int status;
        struct strbuf branch_ref = STRBUF_INIT;
  
+       if (!opts->new_branch)
+               die(_("You are on a branch yet to be born"));
        strbuf_addf(&branch_ref, "refs/heads/%s", opts->new_branch);
        status = create_symref("HEAD", branch_ref.buf, "checkout -b");
        strbuf_release(&branch_ref);
@@@ -947,7 -955,6 +949,7 @@@ int cmd_checkout(int argc, const char *
                            3),
                OPT__FORCE(&opts.force, "force checkout (throw away local modifications)"),
                OPT_BOOLEAN('m', "merge", &opts.merge, "perform a 3-way merge with the new branch"),
 +              OPT_BOOLEAN(0, "overwrite-ignore", &opts.overwrite_ignore, "update ignored files (default)"),
                OPT_STRING(0, "conflict", &conflict_style, "style",
                           "conflict style (merge or diff3)"),
                OPT_BOOLEAN('p', "patch", &patch_mode, "select hunks interactively"),
  
        memset(&opts, 0, sizeof(opts));
        memset(&new, 0, sizeof(new));
 +      opts.overwrite_ignore = 1;
  
        gitmodules_config();
        git_config(git_checkout_config, &opts);
  
        if (opts.new_branch) {
                struct strbuf buf = STRBUF_INIT;
 -              if (strbuf_check_branch_ref(&buf, opts.new_branch))
 -                      die(_("git checkout: we do not like '%s' as a branch name."),
 -                          opts.new_branch);
 -              if (ref_exists(buf.buf)) {
 -                      opts.branch_exists = 1;
 -                      if (!opts.new_branch_force)
 -                              die(_("git checkout: branch %s already exists"),
 -                                  opts.new_branch);
 -              }
 +
 +              opts.branch_exists = validate_new_branchname(opts.new_branch, &buf,
 +                                                           !!opts.new_branch_force,
 +                                                           !!opts.new_branch_force);
 +
                strbuf_release(&buf);
        }
  
        if (opts.writeout_stage)
                die(_("--ours/--theirs is incompatible with switching branches."));
  
 -      if (!new.commit) {
 +      if (!new.commit && opts.new_branch) {
                unsigned char rev[20];
                int flag;
  
 -              resolve_ref("HEAD", rev, 0, &flag);
 -              if ((flag & REF_ISSYMREF) && is_null_sha1(rev))
 +              if (!read_ref_full("HEAD", rev, 0, &flag) &&
 +                  (flag & REF_ISSYMREF) && is_null_sha1(rev))
                        return switch_unborn_to_new_branch(&opts);
        }
        return switch_branches(&opts, &new);