Merge branch 'jk/alternate-ref-optim' into maint
authorJunio C Hamano <gitster@pobox.com>
Mon, 5 Jun 2017 00:03:14 +0000 (09:03 +0900)
committerJunio C Hamano <gitster@pobox.com>
Mon, 5 Jun 2017 00:03:14 +0000 (09:03 +0900)
A test allowed both "git push" and "git receive-pack" on the other
end write their traces into the same file. This is OK on platforms
that allows atomically appending to a file opened with O_APPEND,
but on other platforms led to a mangled output, causing
intermittent test failures. This has been fixed by disabling
traces from "receive-pack" in the test.

* jk/alternate-ref-optim:
t5400: avoid concurrent writes into a trace file

t/t5400-send-pack.sh
index 3331e0f53443f9a8566d01ac08dd0cbc5aa2d33b..d375d7110d102d6b3ea194e4f09a9b5f391ed496 100755 (executable)
@@ -288,7 +288,10 @@ test_expect_success 'receive-pack de-dupes .have lines' '
        $shared .have
        EOF
 
-       GIT_TRACE_PACKET=$(pwd)/trace git push fork HEAD:foo &&
+       GIT_TRACE_PACKET=$(pwd)/trace \
+           git push \
+               --receive-pack="unset GIT_TRACE_PACKET; git-receive-pack" \
+               fork HEAD:foo &&
        extract_ref_advertisement <trace >refs &&
        test_cmp expect refs
 '